requests validation hotfix #8156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Feb 4, 2025
src/Nethermind/Nethermind.Merge.Plugin/Data/IExecutionPayloadParams.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Feb 4, 2025
Contributor
MarekM25
left a comment
MarekM25
left a comment
There was a problem hiding this comment.
The PR looks good, but you have to add tests
Contributor
Author
Okay adding few tests |
LukaszRozmej
approved these changes
Feb 4, 2025
kamilchodola
pushed a commit
that referenced
this pull request
Feb 8, 2025
kamilchodola
added a commit
that referenced
this pull request
Feb 12, 2025
This reverts commit 471d181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate changes from ethereum/execution-spec-tests#1139
Origin of this issue: ethereum/execution-spec-tests#1138, ethereum/execution-spec-tests#1138 (review)