fix: map ExecutionType.TXCREATE to Instruction.EOFCREATE #9813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forostovec
requested review from
Demuirgos,
LukaszRozmej and
benaadams
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TXCREATE is used as the top-level execution type for EOF contract creation in TransactionProcessor, but
ExecutionTypeExtensions.ToInstruction() did not handle it, causing a NotSupportedException during tracing when
NativeCallTracer.ReportAction() converts the execution type to an opcode. Mapping TXCREATE to EOFCREATE aligns with how TRANSACTION maps to CALL and with the semantics of EOF creation where the corresponding instruction is EOFCREATE.