fix: handle null ExcessBlobGas in EIP-7918 calculation #9888
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strmfos
requested review from
Demuirgos,
LukaszRozmej and
benaadams
as code owners
Contributor
|
Does it make difference? Could you add a test that reveals it if so? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the EIP-7918 blob gas calculation where the return value of TryCalculateFeePerBlobGas was ignored, potentially causing incorrect calculations when parentBlockHeader.ExcessBlobGas is null.
Key Changes:
- Changed the call from using the BlockHeader overload to using the ulong overload with the already-extracted
excessBlobGasvalue that properly handles null through null-coalescing
Contributor
Author
|
Added a test for the null case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockHeader overload of TryCalculateFeePerBlobGas sets feePerBlobGas to UInt256.MaxValue when ExcessBlobGas is null, but return value was ignored. Use already extracted excessBlobGas (line 108) instead.