fix: map InvalidBlockRangeUpdate to BreachOfProtocol #9891
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Dec 6, 2025
alexb5dh
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously DisconnectReason.InvalidBlockRangeUpdate was not handled explicitly in
DisconnectReasonExtension.ToEthDisconnectReason and therefore fell through to EthDisconnectReason.Other. This meant that invalid BlockRangeUpdate messages in Eth69ProtocolHandler were reported on the wire as a generic “Other” disconnect instead of a protocol breach, and static peers sending such invalid updates were treated more leniently than other sync-related protocol violations. This change maps InvalidBlockRangeUpdate to EthDisconnectReason.BreachOfProtocol, aligning it with the rest of the sync validation errors, improving disconnect diagnostics and ensuring consistent handling for both regular and static peers.