Various fixes and improvements found by LLVM's scan-build

As reported by http://dev.yorhel.nl/ncdc/bug/64

Author: Yorhel

src/cc.c

@@ -847,7 +847,7 @@ static void adc_handle(net_t *net, char *msg, int _len) {
   }
 
   if(cmd.type != 'C') {
-    g_message("CC:%s: Not a client command: %s. --> %s", net_remoteaddr(cc->net), err->message, msg);
+    g_message("CC:%s: Not a client command: %s", net_remoteaddr(cc->net), msg);
     g_strfreev(cmd.argv);
     return;
   }

src/commands.c

@@ -56,7 +56,7 @@ static cmd_t *getcmd(const char *name) {
 // Get documentation for a command. May be slow at first, but caches the doc
 // structure later on.
 static doc_cmd_t *getdoc(cmd_t *cmd) {
-  doc_cmd_t empty = { "", NULL, "No documentation available." };
+  static doc_cmd_t empty = { "", NULL, "No documentation available." };
   if(cmd->doc)
     return cmd->doc;
   doc_cmd_t *i = (doc_cmd_t *)doc_cmds;
@@ -416,7 +416,6 @@ static void c_open(char *args) {
     return;
   }
 
-  ui_tab_t *tab = ui_tab_cur->data;
   gboolean conn = TRUE;
   if(strncmp(args, "-n ", 3) == 0) {
     conn = FALSE;
@@ -444,16 +443,13 @@ static void c_open(char *args) {
     }
     // Open or select tab
     if(!n) {
-      tab = uit_hub_create(name, addr ? FALSE : conn);
+      ui_tab_t *tab = uit_hub_create(name, addr ? FALSE : conn);
       ui_tab_open(tab, TRUE, NULL);
       listen_refresh();
-    } else if(n != ui_tab_cur) {
+    } else if(n != ui_tab_cur)
       ui_tab_cur = n;
-      tab = n->data;
-    } else {
+    else
       ui_m(NULL, 0, addr ? "Tab already selected, saving new address instead." : "Tab already selected.");
-      tab = n->data;
-    }
     // Save address and (re)connect when necessary
     if(addr && c_connect_set_hubaddr(addr) && conn)
       c_reconnect("");

src/fl_util.c

@@ -280,7 +280,7 @@ fl_list_t *fl_list_from_path(fl_list_t *root, const char *path) {
 void fl_list_suggest(fl_list_t *root, char *opath, char **sug) {
   fl_list_t *parent = root;
   char *path = g_strdup(opath);
-  char *name = path;
+  char *name;
   char *sep = strrchr(path, '/');
   if(sep) {
     *sep = 0;

src/net.c

@@ -1307,7 +1307,8 @@ void net_disconnect(net_t *n) {
   case NETST_ASY:
   case NETST_DIS:
     n->rd_cb = NULL;
-    if(n->syn) {
+    s = n->syn;
+    if(s) {
       syn_cancel(n);
       syn_free(s);
     }

src/search.c

@@ -537,7 +537,7 @@ gboolean search_handle_udp(const char *addr, char *pack, int len) {
   }
 
   // handle message
-  char *next = msg;
+  char *next;
   while((next = strchr(msg, adc ? '\n' : '|')) != NULL) {
     *(next++) = 0;
     g_debug("%s:%s< %s", sudp ? "SUDP" : "UDP", addr, msg);

src/util.c

@@ -467,8 +467,8 @@ gboolean file_move(const char *from, const char *to, gboolean overwrite, GError
     if(r <= 0)
       break;
 
+    char *p = buf;
     while(r > 0) {
-      char *p = buf;
       int w = write(tofd, p, r);
       if(w < 0 && errno == EINTR)
         continue;