Merge branch 'master' into refactor_nev_header_reading

Author: h-mayorquin

neo/rawio/spikegadgetsrawio.py

@@ -109,16 +109,13 @@ def _produce_ephys_channel_ids(self, n_total_channels, n_channels_per_chip, miss
 
     def _parse_header(self):
         # parse file until "</Configuration>"
-        header_size = None
         with open(self.filename, mode="rb") as f:
-            while True:
-                line = f.readline()
+            for line in f:
                 if b"</Configuration>" in line:
                     header_size = f.tell()
                     break
-
-            if header_size is None:
-                ValueError("SpikeGadgets: the xml header does not contain '</Configuration>'")
+            else:
+                raise ValueError("SpikeGadgets: the xml header does not contain '</Configuration>'")
 
             f.seek(0)
             header_txt = f.read(header_size).decode("utf8")

neo/test/rawiotest/test_spikegadgetsrawio.py

@@ -1,5 +1,6 @@
 import unittest
 from pathlib import Path
+import tempfile
 
 from neo.rawio.spikegadgetsrawio import SpikeGadgetsRawIO
 from neo.test.rawiotest.common_rawio_test import BaseTestRawIO
@@ -51,3 +52,17 @@ def test_parse_header_missing_channels(self):
             ]
             # fmt: on
         )
+
+    def test_opening_gibberish_file(self):
+        """Test that parsing a file without </Configuration> raises ValueError instead of infinite loop."""
+        # Create a temporary file with gibberish content that doesn't have the required tag
+        with tempfile.NamedTemporaryFile(mode='wb', suffix='.rec') as temp_file:
+            # Write simple gibberish content without the required </Configuration> tag
+            temp_file.write(b"gibberish\n")
+            temp_file.flush()
+            
+            reader = SpikeGadgetsRawIO(filename=temp_file.name)
+            with self.assertRaises(ValueError) as cm:
+                reader.parse_header()
+            
+            self.assertIn("xml header does not contain '</Configuration>'", str(cm.exception))