Skip to content

Commit 84952cd

Browse files
Apply suggestions from code review
Co-authored-by: Julia Sprenger <[email protected]>
1 parent 19c43f9 commit 84952cd

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

.github/workflows/full-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
# needed for correct operation of git/git-annex/DataLad
3939
git config --global user.email "neo_ci@fake_mail.com"
4040
git config --global user.name "neo CI"
41-
# create an environement and install everything
41+
# create an environment and install everything
4242
python -m venv ~/test_env
4343
source ~/test_env/bin/activate
4444
python -m pip install --upgrade pip

neo/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
logging_handler = logging.StreamHandler()
99

1010
from neo.core import *
11-
# import neo.rawio
1211
from neo.io import *
1312

1413
from neo.version import version as __version__

neo/test/iotest/common_io_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def get_local_base_folder(self):
182182
def get_local_path(self, sub_path):
183183
root_local_path = self.get_local_base_folder()
184184
local_path = root_local_path / sub_path
185-
# TODO later : remove the str when all IOs handle the Path stuff
185+
# TODO later : remove the str when all IOs handle the pathlib.Path objects
186186
local_path = str(local_path)
187187
return local_path
188188

neo/test/rawiotest/common_rawio_test.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030

3131

3232
# url_for_tests = "https://portal.g-node.org/neo/" #This is the old place
33-
# url_for_tests = "https://web.gin.g-node.org/NeuralEnsemble/ephy_testing_data/raw/master/"
3433
repo_for_test = 'https://gin.g-node.org/NeuralEnsemble/ephy_testing_data'
3534

3635
class BaseTestRawIO:
@@ -72,7 +71,7 @@ def get_local_base_folder(self):
7271
def get_local_path(self, sub_path):
7372
root_local_path = self.get_local_base_folder()
7473
local_path = root_local_path / sub_path
75-
# TODO later : remove the str when all IOs handle the Path stuff
74+
# TODO later : remove the str when all IOs handle the pathlib.Path objects
7675
local_path = str(local_path)
7776
return local_path
7877

neo/test/rawiotest/test_examplerawio.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ class and a full test will be done to test if the new coded IO
3131

3232
class TestExampleRawIO(BaseTestRawIO, unittest.TestCase, ):
3333
rawioclass = ExampleRawIO
34-
# here obsvisously there is nothing to download:
34+
# here obliviously there is nothing to download:
3535
entities_to_download = []
36-
# here we will test 1 fake files
36+
37+
# here we will test 1 fake file
3738
# note that for IOs based on directory names you can put the directory
38-
# name here instead of the file name.
39+
# name here instead of the filename.
3940
entities_to_test = ['fake1']
4041

4142

neo/utils/datasets.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
Some simple function to retrieve public datasets.
2+
Utility functions to retrieve public datasets.
33
"""
44
from pathlib import Path
55
import os
@@ -48,6 +48,7 @@ def download_dataset(repo=None, remote_path=None, local_folder=None):
4848
The distant path to retrieve (file or folder)
4949
local_folder: str or Path or None
5050
The local folder where to download the data.
51+
If None, a default project testing folder is used. Default: None
5152
5253
Returns:
5354
--------

0 commit comments

Comments
 (0)