Skip to content

Commit e5b67a8

Browse files
committed
changes
1 parent 47083fa commit e5b67a8

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

neo/rawio/neuralynxrawio/neuralynxrawio.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,9 @@ def _parse_header(self):
464464
event_channels = np.array(event_channels, dtype=_event_channel_dtype)
465465

466466
if signal_channels.size > 0:
467-
# Build filter configuration registry: filter_id -> filter parameters dict
467+
# Build DSP filter configuration registry: filter_id -> filter parameters dict
468468
# Use temporary dict to deduplicate filter configs while building
469-
_filter_configurations = {} # filter_id -> filter parameters dict
469+
_dsp_filter_configurations = {} # filter_id -> filter parameters dict
470470
seen_filters = {} # filter_params_tuple -> filter_id (temporary)
471471

472472
for stream_key, stream_info in stream_props.items():
@@ -476,12 +476,13 @@ def _parse_header(self):
476476

477477
# Assign filter ID (deduplicated by filter_params_tuple)
478478
if filter_params_tuple not in seen_filters:
479-
filter_id = len(_filter_configurations)
479+
filter_id = len(_dsp_filter_configurations)
480480
seen_filters[filter_params_tuple] = filter_id
481-
_filter_configurations[filter_id] = dict(filter_params_tuple)
481+
_dsp_filter_configurations[filter_id] = dict(filter_params_tuple)
482482

483-
# Store filter configurations as private instance attribute
484-
self._filter_configurations = _filter_configurations
483+
# Store DSP filter configurations as private instance attribute
484+
# Keeping private for now - may expose via annotations or public API in future
485+
self._dsp_filter_configurations = _dsp_filter_configurations
485486

486487
# Order streams by sampling rate (high to low)
487488
ordered_stream_keys = sorted(stream_props.keys(), reverse=True, key=lambda x: x[0])

neo/test/rawiotest/test_neuralynxrawio.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,16 +243,16 @@ def test_two_streams_different_header_encoding(self):
243243
expected_names = {"stream0_32000Hz_100mVRange_DSPFilter0", "stream1_32000Hz_1mVRange_DSPFilter1"}
244244
self.assertEqual(set(stream_names), expected_names)
245245

246-
# Verify filter configurations are stored privately
247-
self.assertTrue(hasattr(rawio, "_filter_configurations"))
248-
self.assertEqual(len(rawio._filter_configurations), 2)
246+
# Verify DSP filter configurations are stored (private for now)
247+
self.assertTrue(hasattr(rawio, "_dsp_filter_configurations"))
248+
self.assertEqual(len(rawio._dsp_filter_configurations), 2)
249249

250250
# Verify filter 0 (eye-tracking): low-cut disabled
251-
filter_0 = rawio._filter_configurations[0]
251+
filter_0 = rawio._dsp_filter_configurations[0]
252252
self.assertFalse(filter_0.get("DSPLowCutFilterEnabled", True))
253253

254254
# Verify filter 1 (ephys): low-cut enabled
255-
filter_1 = rawio._filter_configurations[1]
255+
filter_1 = rawio._dsp_filter_configurations[1]
256256
self.assertTrue(filter_1.get("DSPLowCutFilterEnabled", False))
257257

258258

0 commit comments

Comments
 (0)