Skip to content

Commit ea7d84f

Browse files
committed
test that all rawios accept slice(None)
1 parent 40b07ed commit ea7d84f

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

neo/test/rawiotest/rawio_compliance.py

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def read_analogsignals(reader):
172172
channel_names = signal_channels["name"][mask]
173173
channel_ids = signal_channels["id"][mask]
174174

175-
# acces by channel inde/ids/names should give the same chunk
175+
# acces by channel index/ids/names should give the same chunk
176176
channel_indexes2 = channel_indexes[::2]
177177
channel_names2 = channel_names[::2]
178178
channel_ids2 = channel_ids[::2]
@@ -214,6 +214,29 @@ def read_analogsignals(reader):
214214
)
215215
np.testing.assert_array_equal(raw_chunk0, raw_chunk1)
216216

217+
# test slice(None). This should return the same array as giving
218+
# all channel indexes or using None as an argument in `get_analogsignal_chunk`
219+
# see https://github.com/NeuralEnsemble/python-neo/issues/1533
220+
221+
raw_chunk_slice_none = reader.get_analogsignal_chunk(
222+
block_index=block_index,
223+
seg_index=seg_index,
224+
i_start=i_start,
225+
i_stop=i_stop,
226+
stream_index=stream_index,
227+
channel_indexes=slice(None)
228+
)
229+
raw_chunk_channel_indexes = reader.get_analogsignal_chunk(
230+
block_index=block_index,
231+
seg_index=seg_index,
232+
i_start=i_start,
233+
i_stop=i_stop,
234+
stream_index=stream_index,
235+
channel_indexes=channel_indexes
236+
)
237+
238+
np.testing.assert_array_equal(raw_chunk_slice_none, raw_chunk_channel_indexes)
239+
217240
# test prefer_slice=True/False
218241
if nb_chan >= 3:
219242
for prefer_slice in (True, False):

0 commit comments

Comments
 (0)