Fix a memory leak by introducing destructor for InputQueryBuilder (#860)

* Fix a memory leak by introducing destructor for InputQueryBuilder

* Clear lists after building Query in InputQueryBuilder.

This way the responsibility for deleting items there is passed to the caller.

---------

Co-authored-by: Reuven Peleg <reuvenp@mobileye.com>

Author: R-Peleg

src/input_parsers/InputQueryBuilder.cpp

@@ -133,18 +133,21 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         query.markInputVariable( inputVar, i );
         i++;
     }
+    _inputVars.clear();
 
     int j = 0;
     for ( Variable outputVar : _outputVars )
     {
         query.markOutputVariable( outputVar, j );
         j++;
     }
+    _outputVars.clear();
 
     for ( Equation equation : _equationList )
     {
         query.addEquation( equation );
     }
+    _equationList.clear();
 
     for ( ReluConstraint *constraintPtr : _reluList )
     {
@@ -154,6 +157,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addPiecewiseLinearConstraint( constraintPtr );
     }
+    _reluList.clear();
 
     for ( LeakyReluConstraint *constraintPtr : _leakyReluList )
     {
@@ -163,6 +167,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addPiecewiseLinearConstraint( constraintPtr );
     }
+    _leakyReluList.clear();
 
     for ( SigmoidConstraint *constraintPtr : _sigmoidList )
     {
@@ -172,6 +177,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addNonlinearConstraint( constraintPtr );
     }
+    _sigmoidList.clear();
 
     for ( MaxConstraint *constraintPtr : _maxList )
     {
@@ -185,6 +191,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addPiecewiseLinearConstraint( constraintPtr );
     }
+    _maxList.clear();
 
     for ( AbsoluteValueConstraint *constraintPtr : _absList )
     {
@@ -194,6 +201,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addPiecewiseLinearConstraint( constraintPtr );
     }
+    _absList.clear();
 
     for ( SignConstraint *constraintPtr : _signList )
     {
@@ -203,6 +211,7 @@ void InputQueryBuilder::generateQuery( IQuery &query )
         } );
         query.addPiecewiseLinearConstraint( constraintPtr );
     }
+    _signList.clear();
 
     // TODO check this last two
     for ( std::pair<Variable, float> lower : _lowerBounds )
@@ -231,3 +240,42 @@ Equation *InputQueryBuilder::findEquationWithOutputVariable( Variable variable )
     }
     return NULL;
 }
+
+InputQueryBuilder::~InputQueryBuilder()
+{
+    for ( ReluConstraint *constraintPtr : _reluList )
+    {
+        delete constraintPtr;
+    }
+    _reluList = {};
+
+    for ( LeakyReluConstraint *constraintPtr : _leakyReluList )
+    {
+        delete constraintPtr;
+    }
+    _leakyReluList = {};
+
+    for ( SigmoidConstraint *constraintPtr : _sigmoidList )
+    {
+        delete constraintPtr;
+    }
+    _sigmoidList = {};
+
+    for ( MaxConstraint *constraintPtr : _maxList )
+    {
+        delete constraintPtr;
+    }
+    _maxList = {};
+
+    for ( AbsoluteValueConstraint *constraintPtr : _absList )
+    {
+        delete constraintPtr;
+    }
+    _absList = {};
+
+    for ( SignConstraint *constraintPtr : _signList )
+    {
+        delete constraintPtr;
+    }
+    _signList = {};
+}

src/input_parsers/InputQueryBuilder.h

@@ -75,6 +75,7 @@ class InputQueryBuilder
     void generateQuery( IQuery &query );
 
     Equation *findEquationWithOutputVariable( Variable variable );
+    virtual ~InputQueryBuilder();
 };
 
 #endif // __InputQueryBuilder_h__