Adding <ionChannelVShift> and <channelDensityVShift> where vShift in a channel can be set

Author: pgleeson

NeuroML2CoreTypes/Cells.xml

@@ -244,6 +244,8 @@
         description="Specifies a time varying ohmic conductance density, _gDensity, which is distributed on an area of the cell with fixed reversal potential _erev producing a current density _iDensity">
 
         <Parameter name="erev" dimension="voltage"/>
+        
+        <Constant name="vShift" dimension="voltage" value="0mV" description="Set to a constant 0mV here to allow ion channels which use _vShift in their rate variable expressions to be used with _channelDensity_, not just with _channelDensityVShift_ (where _vShift would be explicitly set)"/>
 
         <!-- TODO: Ensure Text elements are inherited from base type -->
         <Text name="segmentGroup"/>
@@ -266,6 +268,23 @@
 
     </ComponentType>
 
+    <ComponentType name="channelDensityVShift"
+        extends="channelDensity"
+        description="Same as _channelDensity_, but with a _vShift parameter to change voltage activation of gates. The exact usage of _vShift in expressions for rates is determined by the individual gates.">
+
+        <Parameter name="vShift" dimension="voltage"/>
+
+        <!-- TODO: Ensure Text elements are inherited from base type -->
+        <Text name="segmentGroup"/>
+        <Text name="ion"/> <!-- TODO: Ideally this needs to be a property of ionChannel only!
+                                But it's here as it makes it easier to select channelPopulations transmitting specific ions...-->
+
+        <Structure>
+            <ChildInstance component="ionChannel"/>
+        </Structure>
+
+    </ComponentType>
+
 
     <ComponentType name="channelDensityNernst"
         extends="baseChannelDensityCond"

NeuroML2CoreTypes/Channels.xml

@@ -549,6 +549,17 @@
         </Dynamics>
 
     </ComponentType>
+
+    <ComponentType name="ionChannelVShift"
+                   extends="ionChannel"
+                   description="Same as _ionChannel_, but with a _vShift parameter to change voltage activation of gates. The exact usage of _vShift in expressions for rates is determined by the individual gates.">
+        
+        
+        <Parameter name="vShift" dimension="voltage"/>
+        <!-- TODO: Ensure Text elements are inherited from base type -->
+        <Text name="species"/>
+
+    </ComponentType>
 
 
     <ComponentType name="KSState"

Schemas/NeuroML2/NeuroML_v2beta5.xsd

@@ -436,6 +436,8 @@
                     remove one of these -->
                     <xs:element name="ionChannelHH" type="IonChannelHH" minOccurs="0" maxOccurs="unbounded"/>
 
+                    <xs:element name="ionChannelVShift" type="IonChannelVShift" minOccurs="0" maxOccurs="unbounded"/>
+                    
                     <xs:element name="ionChannelKS" type="IonChannelKS" minOccurs="0" maxOccurs="unbounded"/>
 
                     <xs:group ref="ConcentrationModelTypes"/>
@@ -690,6 +692,17 @@
         </xs:complexContent>
     </xs:complexType>
 
+    <xs:complexType name="IonChannelVShift">
+        <xs:annotation>
+            <xs:documentation>Same as ionChannel, but with a vShift parameter to change voltage activation of gates. The exact usage of vShift in expressions for rates is determined by the individual gates.</xs:documentation>
+        </xs:annotation>
+        <xs:complexContent>
+            <xs:extension base="IonChannel">
+                <xs:attribute name="vShift" type="Nml2Quantity_voltage" use="required"/>
+            </xs:extension>
+        </xs:complexContent>
+    </xs:complexType>
+
 
     <xs:simpleType name="channelTypes">
         <xs:restriction base="xs:string">
@@ -1690,6 +1703,7 @@
             <xs:element name="channelPopulation" type="ChannelPopulation" minOccurs="0" maxOccurs="unbounded"/>
 
             <xs:element name="channelDensity" type="ChannelDensity" minOccurs="0" maxOccurs="unbounded"/>
+            <xs:element name="channelDensityVShift" type="ChannelDensityVShift" minOccurs="0" maxOccurs="unbounded"/>
             <xs:element name="channelDensityNernst" type="ChannelDensityNernst" minOccurs="0" maxOccurs="unbounded"/>
             <xs:element name="channelDensityGHK" type="ChannelDensityGHK" minOccurs="0" maxOccurs="unbounded"/>
             <xs:element name="channelDensityGHK2" type="ChannelDensityGHK2" minOccurs="0" maxOccurs="unbounded"/>
@@ -1923,6 +1937,17 @@
     </xs:complexType>
 
 
+    <xs:complexType name="ChannelDensityVShift">
+
+        <xs:complexContent>
+            <xs:extension base="ChannelDensity">
+                
+                <xs:attribute name="vShift" type="Nml2Quantity_voltage" use="required"/>
+            </xs:extension>
+        </xs:complexContent>
+
+    </xs:complexType>
+
 
 
     <xs:complexType name="ChannelDensityNernst">