Skip to content

Commit 29f166b

Browse files
committed
feat(rag): remove memory from answer generator
Not needed: confuses it if enough context is not available
1 parent 8ff704f commit 29f166b

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

rag_pkg/gen_rag/rag.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -407,13 +407,14 @@ def _generate_answer_from_context_node(self, state: RAGState) -> dict:
407407
408408
""")
409409

410-
if self.memory:
411-
system_prompt += add_memory_to_prompt(
412-
messages=state.messages,
413-
context_summary=state.context_summary,
414-
num_recent_messages=self.num_recent_messages,
415-
)
416-
410+
# Do not add memory at this step: limit to provided context
411+
# if self.memory:
412+
# system_prompt += add_memory_to_prompt(
413+
# messages=state.messages,
414+
# context_summary=state.context_summary,
415+
# num_recent_messages=self.num_recent_messages,
416+
# )
417+
#
417418
generate_answer_template = ChatPromptTemplate(
418419
[
419420
("system", system_prompt),
@@ -589,11 +590,10 @@ def _evaluate_answer_node(self, state: RAGState) -> dict:
589590
* 0.0 - 0.3: verbose
590591
591592
Guidelines for 'next_step':
592-
1. high coverage, confident, relevant, grounded, with acceptable
593-
coherence and conciseness: return "continue".
593+
1. high coverage, confident, relevant, grounded, with acceptable coherence and conciseness: return "continue".
594594
2. low coverage: return "modify_query".
595-
3. high coverage, low confidence: return "retrieve_more_info".
596-
4. high coverage and confidence, low relevance, groundedness, coherence, or conciseness: return "rewrite_answer"
595+
3. low confidence: return "retrieve_more_info".
596+
4. high coverage and confidence, low relevance, low groundedness, low coherence, or low conciseness: return "rewrite_answer"
597597
5. all coverage, confidence, relevance and groundedness are low: return "undefined".
598598
599599
Always return a brief summary.

0 commit comments

Comments
 (0)