fix pynwb table issue and try returning generator

Author: CodyCBakerPhD

nwbinspector/nwbinspector.py

@@ -493,7 +493,7 @@ def _collect_all_messages(
                 )
 
     if driver != "ros3":
-        yield _collect_all_messages(
+        return _collect_all_messages(
             nwbfile_path=nwbfile_path, checks=checks, driver=driver, skip_validate=skip_validate
         )
     else:
@@ -502,7 +502,7 @@ def _collect_all_messages(
         while retries < max_retries:
             try:
                 retries += 1
-                yield _collect_all_messages(
+                return _collect_all_messages(
                     nwbfile_path=nwbfile_path, checks=checks, driver=driver, skip_validate=skip_validate
                 )
             except OSError:  # Cannot curl request

tests/unit_tests/test_tables.py

@@ -1,6 +1,7 @@
 import platform
 import json
 from unittest import TestCase
+from packaging import version
 
 import numpy as np
 from hdmf.common import DynamicTable, DynamicTableRegion
@@ -17,6 +18,7 @@
     check_single_row,
     check_table_values_for_dict,
 )
+from nwbinspector.utils import get_package_version
 
 
 class TestCheckDynamicTableRegion(TestCase):
@@ -237,16 +239,27 @@ def test_check_single_row_ignore_electrodes():
     table = ElectrodeTable(
         name="electrodes",  # default name when building through nwbfile
     )
-    table.add_row(
-        x=np.nan,
-        y=np.nan,
-        z=np.nan,
-        imp=np.nan,
-        location="unknown",
-        filtering="unknown",
-        group=ElectrodeGroup(name="test_group", description="", device=Device(name="test_device"), location="unknown"),
-        group_name="test_group",
-    )
+    if get_package_version(name="pynwb") >= version.Version("2.1.0"):
+        table.add_row(
+            location="unknown",
+            group=ElectrodeGroup(
+                name="test_group", description="", device=Device(name="test_device"), location="unknown"
+            ),
+            group_name="test_group",
+        )
+    else:
+        table.add_row(
+            x=np.nan,
+            y=np.nan,
+            z=np.nan,
+            imp=np.nan,
+            location="unknown",
+            filtering="unknown",
+            group=ElectrodeGroup(
+                name="test_group", description="", device=Device(name="test_device"), location="unknown"
+            ),
+            group_name="test_group",
+        )
     assert check_single_row(table=table) is None