addressed noncoplanar polygons bug

Author: JansenSmith

src/main/java/eu/mihosoft/vrl/v3d/CSG.java

@@ -1951,13 +1951,7 @@ public CSG transformed(Transform transform) {
 		}
 
 		List<Polygon> newpolygons = this.getPolygons().stream().map(p -> {
-			try {
-				return p.transformed(transform);
-			} catch (Exception e) {
-				// e.printStackTrace();
-				System.err.println("Removing Polygon during transform");
-				return null;
-			}
+			return p.transformed(transform);
 		}).filter(Objects::nonNull).collect(Collectors.toList());
 
 		CSG csg = CSG.fromPolygons(newpolygons).optimization(getOptType());

src/main/java/eu/mihosoft/vrl/v3d/Plane.java

@@ -391,8 +391,8 @@ else if (somePointsInBack) {
 			back.add(polygon);
 			break;
 		case SPANNING:
-			List<Vertex> f = new ArrayList<>();
-			List<Vertex> b = new ArrayList<>();
+			ArrayList<Vertex> f = new ArrayList<>();
+			ArrayList<Vertex> b = new ArrayList<>();
 			for (int i = 0; i < polygon.vertices.size(); i++) {
 				int j = (i + 1) % polygon.vertices.size();
 				PlaneType ti = types.get(i);
@@ -415,17 +415,18 @@ else if (somePointsInBack) {
 				}
 			}
 			try {
-				front.add(new Polygon(f, polygon.getStorage()).setColor(polygon.getColor()));
+				Polygon.arePointsCoplanar(f,polygon.plane.getNormal());
+				front.add(new Polygon(f, polygon.getStorage(), true, polygon.plane).setColor(polygon.getColor()));
 			} catch (Exception ex) {
-				 ex.printStackTrace();
+				ex.printStackTrace();
 				System.err.println("Pruning bad polygon Plane::splitPolygon");
 				// skip adding broken polygon here
 			}
 
 			try {
-				back.add(new Polygon(b, polygon.getStorage()).setColor(polygon.getColor()));
+				back.add(new Polygon(b, polygon.getStorage(), true, polygon.plane).setColor(polygon.getColor()));
 			} catch (Exception ex) {
-				 ex.printStackTrace();
+				ex.printStackTrace();
 				System.err.println("Pruning bad polygon Plane::splitPolygon");
 			}
 

src/main/java/eu/mihosoft/vrl/v3d/Polygon.java

@@ -114,6 +114,23 @@ public Polygon(List<Vertex> vertices, PropertyStorage shared, boolean allowDegen
 		validateAndInit();
 	}
 
+	/**
+	 * Constructor. Creates a new polygon that consists of the specified vertices.
+	 *
+	 * Note: the vertices used to initialize a polygon must be coplanar and form a
+	 * convex loop.
+	 *
+	 * @param vertices polygon vertices
+	 * @param shared   shared property
+	 */
+	public Polygon(List<Vertex> vertices, PropertyStorage shared, boolean allowDegenerate, Plane p) {
+		this.plane = p;
+		this.vertices = pruneDuplicatePoints(vertices);
+		this.shared = shared;
+
+		validateAndInit();
+	}
+
 	/**
 	 * Constructor. Creates a new polygon that consists of the specified vertices.
 	 *
@@ -166,7 +183,8 @@ public static ArrayList<Vertex> pruneDuplicatePoints(List<Vertex> incoming) {
 	}
 
 	public void validateAndInit() {
-		this.plane = Plane.createFromPoints(vertices);
+		if(plane==null)
+			this.plane = Plane.createFromPoints(vertices);
 		for (Vertex v : vertices) {
 			v.normal = plane.getNormal();
 			// v.pos.roundToEpsilon();
@@ -184,9 +202,11 @@ public void validateAndInit() {
 
 		if (areAllPointsCollinear(vertices))
 			throw new RuntimeException("This polygon is colinear");
-		if(!arePointsCoplanar(vertices,plane.getNormal()))
-			throw new RuntimeException("All points are not on plane of epsilon "+Plane.getEPSILON());
-
+		if(!arePointsCoplanar(vertices,plane.getNormal())) {
+			this.plane = Plane.createFromPoints(vertices);
+			if(!arePointsCoplanar(vertices,plane.getNormal()))
+				throw new RuntimeException("All points are not on plane of epsilon "+Plane.getEPSILON());
+		}
 		setDegenerate(false);
 
 	}
@@ -295,7 +315,7 @@ public Polygon clone() {
 		this.vertices.forEach((vertex) -> {
 			newVertices.add(vertex.clone());
 		});
-		return new Polygon(newVertices, getStorage(), true).setColor(color);
+		return new Polygon(newVertices, getStorage(), true, this.plane).setColor(color);
 	}
 
 	/**