Merge pull request #216 from MrDOS/bugfix/fix-uucp-check-file-descriptor-leak

MrDOS · web-flow · commit 5d48a20bac48 · 2021-05-04T20:47:45.000+01:00
Fix FD leak when checking lock dir permissions.
diff --git a/src/main/c/src/SerialImp.c b/src/main/c/src/SerialImp.c
@@ -5835,7 +5835,7 @@ int check_group_uucp()
 	strcat(testLockAbsFileName, testLockFileDirName);
 	strcat(testLockAbsFileName, "/");
 	strcat(testLockAbsFileName, testLockFileName);
-	if ( 0 == mkstemp(testLockAbsFileName) )
+	if ( 0 == strlen(mktemp(testLockAbsFileName)) )
 	{
 		free(testLockAbsFileName);
 		report_error("check_group_uucp(): mktemp malformed string - \

Original file line number	Diff line number	Diff line change
`@@ -5835,7 +5835,7 @@ int check_group_uucp()`
`5835`	`5835`	`strcat(testLockAbsFileName, testLockFileDirName);`
`5836`	`5836`	`strcat(testLockAbsFileName, "/");`
`5837`	`5837`	`strcat(testLockAbsFileName, testLockFileName);`
`5838`		`- if ( 0 == mkstemp(testLockAbsFileName) )`
	`5838`	`+ if ( 0 == strlen(mktemp(testLockAbsFileName)) )`
`5839`	`5839`	`{`
`5840`	`5840`	`free(testLockAbsFileName);`
`5841`	`5841`	`report_error("check_group_uucp(): mktemp malformed string - \`