Merge pull request #12 from NeverMorewd/fix/design-tokens-audit

fix: replace hardcoded magic numbers with design tokens (closes #9)

Author: NeverMorewd

src/Pipboy.Avalonia/PipboyTheme.cs

@@ -1,4 +1,5 @@
 using System;
+using Avalonia.Controls;
 using Avalonia.Markup.Xaml;
 using Avalonia.Media;
 using Avalonia.Styling;
@@ -103,14 +104,25 @@ public PipboyTheme(IServiceProvider? serviceProvider = null)
         Resources["PipboyScanBeamColor"]   = Color.FromArgb(40, p.Primary.R, p.Primary.G, p.Primary.B);
 
         // Font design tokens
-        Resources["PipboyFontFamily"]   = new FontFamily("Consolas,Courier New,monospace");
-        Resources["PipboyFontSize"]      = 13.0;
-        Resources["PipboyFontSizeSmall"] = 11.0;
-        Resources["PipboyFontSizeLarge"] = 16.0;
+        Resources["PipboyFontFamily"]      = new FontFamily("Consolas,Courier New,monospace");
+        Resources["PipboyFontSize"]        = 13.0;
+        Resources["PipboyFontSizeXSmall"]  = 10.0;
+        Resources["PipboyFontSizeSmall"]   = 11.0;
+        Resources["PipboyFontSizeLarge"]   = 16.0;
 
         // Spacing / sizing design tokens
         Resources["PipboyControlHeight"]      = 30.0;
         Resources["PipboyTreeViewItemIndent"] = 16.0;
+        Resources["PipboyPickerRowHeight"]    = new GridLength(29);
+        Resources["PipboyPickerItemHeight"]   = 40.0;
+        Resources["PipboyPopupMaxHeight"]     = 200.0;
+
+        // Opacity design tokens
+        Resources["PipboyDisabledOpacity"] = 0.45;
+        Resources["PipboyDimOpacity"]      = 0.7;
+
+        // Stroke design tokens
+        Resources["PipboyIconStrokeThickness"] = 1.5;
 
         // Load compiled AXAML styles — AvaloniaXamlLoader.Load uses the compiled (NativeAOT-safe)
         // version generated from PipboyTheme.axaml; the StyleInclude chain inside that AXAML file

src/Pipboy.Avalonia/Styles/Controls/AutoCompleteBox.axaml

@@ -28,7 +28,7 @@
                             <!--  Dropdown suggestions popup  -->
                             <Popup
                                 Name="PART_Popup"
-                                MaxHeight="200"
+                                MaxHeight="{DynamicResource PipboyPopupMaxHeight}"
                                 IsLightDismissEnabled="True"
                                 IsOpen="False"
                                 Placement="BottomEdgeAlignedLeft"
@@ -40,7 +40,7 @@
                                     CornerRadius="0">
                                     <ListBox
                                         Name="PART_SelectingItemsControl"
-                                        MaxHeight="200"
+                                        MaxHeight="{DynamicResource PipboyPopupMaxHeight}"
                                         Background="Transparent"
                                         BorderThickness="0"
                                         ScrollViewer.VerticalScrollBarVisibility="Auto" />
@@ -52,7 +52,7 @@
             </Setter>
 
             <Style Selector="^:disabled">
-                <Setter Property="Opacity" Value="0.45" />
+                <Setter Property="Opacity" Value="{DynamicResource PipboyDisabledOpacity}" />
             </Style>
         </ControlTheme>
 

src/Pipboy.Avalonia/Styles/Controls/BracketHighlight.axaml

@@ -101,7 +101,7 @@
             </Style>
 
             <Style Selector="^:disabled">
-                <Setter Property="Opacity" Value="0.45" />
+                <Setter Property="Opacity" Value="{DynamicResource PipboyDisabledOpacity}" />
             </Style>
         </ControlTheme>
 

src/Pipboy.Avalonia/Styles/Controls/Button.axaml

@@ -42,7 +42,7 @@
                 <Setter Property="BorderBrush" Value="{DynamicResource PipboyPrimaryBrush}" />
             </Style>
             <Style Selector="^:disabled">
-                <Setter Property="Opacity" Value="0.45" />
+                <Setter Property="Opacity" Value="{DynamicResource PipboyDisabledOpacity}" />
             </Style>
             <Style Selector="^:focus-visible /template/ Border#PART_Border">
                 <Setter Property="BorderBrush" Value="{DynamicResource PipboyBorderFocusBrush}" />

src/Pipboy.Avalonia/Styles/Controls/CheckBox.axaml

@@ -76,7 +76,7 @@
                 <Setter Property="BorderThickness" Value="2" />
             </Style>
             <Style Selector="^:disabled">
-                <Setter Property="Opacity" Value="0.45" />
+                <Setter Property="Opacity" Value="{DynamicResource PipboyDisabledOpacity}" />
             </Style>
         </ControlTheme>
 

src/Pipboy.Avalonia/Styles/Controls/ComboBox.axaml

@@ -83,7 +83,7 @@
                                             VerticalAlignment="Center"
                                             Data="M 4 6 L 8 10 L 12 6"
                                             Stroke="{DynamicResource PipboyTextDimBrush}"
-                                            StrokeThickness="1.5" />
+                                            StrokeThickness="{DynamicResource PipboyIconStrokeThickness}" />
                                     </Border>
                                 </Grid>
                             </Border>
@@ -118,7 +118,7 @@
                 <Setter Property="BorderBrush" Value="{DynamicResource PipboyBorderFocusBrush}" />
             </Style>
             <Style Selector="^:disabled">
-                <Setter Property="Opacity" Value="0.45" />
+                <Setter Property="Opacity" Value="{DynamicResource PipboyDisabledOpacity}" />
             </Style>
         </ControlTheme>