feat: Moved and fixed server side save button

Author: prima

klite.embd

@@ -32517,12 +32517,19 @@ class MarkdownWYSIWYG {
 	}
 
 	showServerSavesPopup = () => {
-		hideAllServerSavingPopups()
-		promptForAdminPassword(() => {
-			reloadSaves().then(() => {
-				serverSavesPopup.classList.remove("hidden")
+		if (is_using_kcpp_with_server_saving())
+		{
+			hideAllServerSavingPopups()
+			promptForAdminPassword(() => {
+				reloadSaves().then(() => {
+					serverSavesPopup.classList.remove("hidden")
+				})
 			})
-		})
+		}
+		else
+		{
+			handleError("Server side saving not enabled: Please check admin tab in KCPP launcher")
+		}
 	}
 
 	hideServerSavesPopup = () => {
@@ -32730,26 +32737,7 @@ class MarkdownWYSIWYG {
 		originalLoadSelectedFile(file)
 	}
 
-	window.addEventListener('load', () => {
-		let hasAppended = false;
-		document.querySelector("#topbtn_save_load .nav-link").onclick = () => {
-			closeTopNav();
-			if (is_using_kcpp_with_server_saving() && !hasAppended) {
-				let serverSideButton = document.createElement("button");
-				serverSideButton.classList.add("btn", "btn-primary")
-				serverSideButton.innerText = "Show saves stored on server"
-				serverSideButton.style = "width: auto;"
-				serverSideButton.onclick = () => {
-					hide_popups()
-					showServerSavesPopup()
-				}
-				let footerButtons = document.querySelector("#saveloadcontainer .popupfooter")
-				footerButtons.insertBefore(serverSideButton, footerButtons.firstChild);
-				hasAppended = true
-			}
-			display_saveloadcontainer()
-		}
-	})
+	// Append button with the third party mod button as that's the one place editing the menu
 
 	let callbackAfterReload = (callback) => {
 		let startTime = Date.now(), intervalId = setInterval(async () => {
@@ -36545,6 +36533,9 @@ flowchart TD\n${treeToViewOutput.outputText.trim()}`
 		let topButton = `<li class="nav-item" id="topbtn_remote_mods">
 				<a class="nav-link mainnav" href="#" onclick="modManager.showModListWarning()" tabindex="0">Third party mods</a>
 			</li>`
+		topButton += `<li class="nav-item" id="topbtn_server_saves">
+			<a class="nav-link mainnav" href="#" onclick="showServerSavesPopup()" tabindex="0">Server saves</a>
+		</li>`
 
 		document.querySelector("#navbarNavDropdown > ul").innerHTML += topButton
 		treeViewer.showOpenButton()