Skip to content

Commit 6ea37f5

Browse files
authored
opencl: fix warnings and clean up profiling (ggml-org#16688)
* opencl: remove unused headers, fix warnings * opencl: clean up profiling, only keep kernel time
1 parent fb34984 commit 6ea37f5

File tree

1 file changed

+9
-16
lines changed

1 file changed

+9
-16
lines changed

ggml/src/ggml-opencl/ggml-opencl.cpp

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515

1616
#include <CL/cl.h>
1717

18+
#include <inttypes.h>
1819
#include <string.h>
1920

2021
#include <cstddef>
2122
#include <cstdint>
22-
#include <atomic>
2323
#include <fstream>
24-
#include <limits>
2524
#include <vector>
2625
#include <string>
2726
#include <cmath>
@@ -533,25 +532,17 @@ struct ggml_backend_opencl_context {
533532
}
534533

535534
// Dump a csv
536-
float total_kernel_time = 0;
537-
fprintf(fperf, "op name, kernel name, queued duration (ms), submit duration(ms), exec duration (ms), complete duration (ms), total duration (ms), global size, local size, output size\n");
535+
fprintf(fperf, "op name, kernel name, exec duration (ms), global size, local size, output size\n");
538536
for (const ProfilingInfo & info : profiling_info) {
539-
total_kernel_time += info.cmd_duration_ns/1.e6f;
540-
fprintf(fperf, "%s,%s,%f,%f,%f,%f,%f,%zux%zux%zu,%zux%zux%zu,%zux%zux%zux%zu\n",
537+
fprintf(fperf, "%s,%s,%f,%zux%zux%zu,%zux%zux%zu,%zux%zux%zux%zu\n",
541538
info.op_name.c_str(), info.kernel_name.c_str(),
542-
info.cmd_queued_duration_ns/1.e6f,
543-
info.cmd_submit_duration_ns/1.e6f,
544539
info.cmd_duration_ns/1.e6f,
545-
info.cmd_complete_duration_ns/1.e6f,
546-
info.cmd_total_duration_ns/1.e6f,
547540
info.global_size[0], info.global_size[1], info.global_size[2],
548541
info.local_size[0], info.local_size[1], info.local_size[2],
549542
info.output_size[0], info.output_size[1], info.output_size[2], info.output_size[3]);
550543
}
551544
fclose(fperf);
552545

553-
GGML_LOG_INFO("ggml_opencl: total kernel time: %f\n", total_kernel_time);
554-
555546
// Dump a simple chrome trace
556547
FILE* ftrace = fopen("cl_trace.json", "w");
557548
if (!ftrace) {
@@ -561,14 +552,14 @@ struct ggml_backend_opencl_context {
561552

562553
fprintf(ftrace, "[\n");
563554
for (const ProfilingInfo & info : profiling_info) {
564-
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"B\", \"ts\": %llu, \"pid\": \"\", \"tid\": \"Host\"},\n",
555+
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"B\", \"ts\": %" PRIu64 ", \"pid\": \"\", \"tid\": \"Host\"},\n",
565556
info.kernel_name.c_str(), info.cmd_queued/1000);
566-
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"E\", \"ts\": %llu, \"pid\": \"\", \"tid\": \"Host\"},\n",
557+
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"E\", \"ts\": %" PRIu64 ", \"pid\": \"\", \"tid\": \"Host\"},\n",
567558
info.kernel_name.c_str(), info.cmd_submit/1000);
568559

569-
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"B\", \"ts\": %llu, \"pid\": \"\", \"tid\": \"Device\"},\n",
560+
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"B\", \"ts\": %" PRIu64 ", \"pid\": \"\", \"tid\": \"Device\"},\n",
570561
info.kernel_name.c_str(), info.cmd_start/1000);
571-
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"E\", \"ts\": %llu, \"pid\": \"\", \"tid\": \"Device\"},\n",
562+
fprintf(ftrace, "{\"name\": \"%s\", \"cat\": \"OpenCL\", \"ph\": \"E\", \"ts\": %" PRIu64 ", \"pid\": \"\", \"tid\": \"Device\"},\n",
572563
info.kernel_name.c_str(), info.cmd_end/1000);
573564
}
574565
fclose(ftrace);
@@ -7652,6 +7643,8 @@ static void ggml_cl_mul_mat_id(ggml_backend_t backend, const ggml_tensor * src0,
76527643
const cl_ulong nb21 = src2->nb[1];
76537644
const cl_ulong nb20 = src2->nb[0];
76547645

7646+
UNUSED(nb20);
7647+
76557648
const int ne0 = dst->ne[0];
76567649
const int ne1 = dst->ne[1];
76577650

0 commit comments

Comments
 (0)