Skip to content

Commit 9cd6a1a

Browse files
committed
allow mmproj to be run on cpu
1 parent f968079 commit 9cd6a1a

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

expose.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ struct load_model_inputs
4545
const int draft_gpulayers = 999;
4646
const float draft_gpusplit[tensor_split_max] = {};
4747
const char * mmproj_filename = nullptr;
48+
const bool mmproj_cpu = false;
4849
const int visionmaxres = 2048;
4950
const bool use_mmap = false;
5051
const bool use_mlock = false;

gpttype_adapter.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2320,6 +2320,11 @@ ModelLoadResult gpttype_load_model(const load_model_inputs inputs, FileFormat in
23202320
printf("Clip will use CPU for this model!\n");
23212321
}
23222322
#endif
2323+
if(inputs.mmproj_cpu)
2324+
{
2325+
set_clip_uses_gpu(false);
2326+
printf("Clip forced to use CPU!\n");
2327+
}
23232328
clp_ctx = clip_model_load(mmproj_filename.c_str(), /*verbosity=*/ 1);
23242329
if(clp_ctx == nullptr) {
23252330
fprintf(stderr, "%s: error: failed to load mmproj model!\n", __func__);

koboldcpp.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ class load_model_inputs(ctypes.Structure):
165165
("draft_gpulayers", ctypes.c_int),
166166
("draft_gpusplit", ctypes.c_float * tensor_split_max),
167167
("mmproj_filename", ctypes.c_char_p),
168+
("mmproj_cpu", ctypes.c_bool),
168169
("visionmaxres", ctypes.c_int),
169170
("use_mmap", ctypes.c_bool),
170171
("use_mlock", ctypes.c_bool),
@@ -1184,6 +1185,7 @@ def load_model(model_filename):
11841185
else:
11851186
inputs.draft_gpusplit[n] = 0
11861187
inputs.mmproj_filename = args.mmproj.encode("UTF-8") if args.mmproj else "".encode("UTF-8")
1188+
inputs.mmproj_cpu = (True if args.mmprojcpu else False)
11871189
inputs.visionmaxres = (512 if args.visionmaxres < 512 else (2048 if args.visionmaxres > 2048 else args.visionmaxres))
11881190
inputs.use_smartcontext = args.smartcontext
11891191
inputs.use_contextshift = (0 if args.noshift else 1)
@@ -3879,6 +3881,7 @@ def hide_tooltip(event):
38793881
preloadstory_var = ctk.StringVar()
38803882
savedatafile_var = ctk.StringVar()
38813883
mmproj_var = ctk.StringVar()
3884+
mmprojcpu_var = ctk.IntVar(value=0)
38823885
visionmaxres_var = ctk.StringVar(value=str(default_visionmaxres))
38833886
draftmodel_var = ctk.StringVar()
38843887
draftamount_var = ctk.StringVar(value=str(default_draft_amount))
@@ -4408,7 +4411,8 @@ def togglerope(a,b,c):
44084411
makefileentry(model_tab, "Text Lora:", "Select Lora File",lora_var, 3,width=280,singlerow=True,tooltiptxt="Select an optional GGML Text LoRA adapter to use.\nLeave blank to skip.")
44094412
makefileentry(model_tab, "Lora Base:", "Select Lora Base File", lora_base_var, 5,width=280,singlerow=True,tooltiptxt="Select an optional F16 GGML Text LoRA base file to use.\nLeave blank to skip.")
44104413
makefileentry(model_tab, "Vision mmproj:", "Select Vision mmproj File", mmproj_var, 7,width=280,singlerow=True,tooltiptxt="Select a mmproj file to use for vision models like LLaVA.\nLeave blank to skip.")
4411-
makelabelentry(model_tab, "Vision MaxRes:", visionmaxres_var, 9, padx=100, singleline=True, tooltip=f"Clamp MMProj vision maximum allowed resolution. Allowed values are between 512 to 2048 px (default {default_visionmaxres}).")
4414+
makecheckbox(model_tab, "Vision Force CPU", mmprojcpu_var, 9, tooltiptxt="Force CLIP for Vision mmproj always on CPU.")
4415+
makelabelentry(model_tab, "Vision MaxRes:", visionmaxres_var, 9, padx=320, singleline=True, tooltip=f"Clamp MMProj vision maximum allowed resolution. Allowed values are between 512 to 2048 px (default {default_visionmaxres}).", labelpadx=220)
44124416
makefileentry(model_tab, "Draft Model:", "Select Speculative Text Model File", draftmodel_var, 11,width=280,singlerow=True,tooltiptxt="Select a draft text model file to use for speculative decoding.\nLeave blank to skip.")
44134417
makelabelentry(model_tab, "Draft Amount: ", draftamount_var, 13, 50,padx=100,singleline=True,tooltip="How many tokens to draft per chunk before verifying results")
44144418
makelabelentry(model_tab, "Splits: ", draftgpusplit_str_vars, 13, 50,padx=210,singleline=True,tooltip="Distribution of draft model layers. Leave blank to follow main model's gpu split. Only works if multi-gpu (All) selected in main model.", labelpadx=160)
@@ -4694,6 +4698,7 @@ def export_vars():
46944698
except Exception:
46954699
pass
46964700
args.mmproj = None if mmproj_var.get() == "" else mmproj_var.get()
4701+
args.mmprojcpu = (mmprojcpu_var.get()==1)
46974702
args.visionmaxres = int(visionmaxres_var.get()) if visionmaxres_var.get()!="" else default_visionmaxres
46984703
args.draftmodel = None if draftmodel_var.get() == "" else draftmodel_var.get()
46994704
args.draftamount = int(draftamount_var.get()) if draftamount_var.get()!="" else default_draft_amount
@@ -4886,6 +4891,7 @@ def import_vars(dict):
48864891
lora_var.set(dict["lora"][0])
48874892

48884893
mmproj_var.set(dict["mmproj"] if ("mmproj" in dict and dict["mmproj"]) else "")
4894+
mmprojcpu_var.set(1 if ("mmprojcpu" in dict and dict["mmprojcpu"]) else 0)
48894895
if "visionmaxres" in dict and dict["visionmaxres"]:
48904896
visionmaxres_var.set(dict["visionmaxres"])
48914897
draftmodel_var.set(dict["draftmodel"] if ("draftmodel" in dict and dict["draftmodel"]) else "")
@@ -6575,6 +6581,7 @@ def range_checker(arg: str):
65756581
advparser.add_argument("--ssl", help="Allows all content to be served over SSL instead. A valid UNENCRYPTED SSL cert and key .pem files must be provided", metavar=('[cert_pem]', '[key_pem]'), nargs='+')
65766582
advparser.add_argument("--nocertify", help="Allows insecure SSL connections. Use this if you have cert errors and need to bypass certificate restrictions.", action='store_true')
65776583
advparser.add_argument("--mmproj", metavar=('[filename]'), help="Select a multimodal projector file for vision models like LLaVA.", default="")
6584+
advparser.add_argument("--mmprojcpu", help="Force CLIP for Vision mmproj always on CPU.", action='store_true')
65786585
advparser.add_argument("--visionmaxres", metavar=('[max px]'), help="Clamp MMProj vision maximum allowed resolution. Allowed values are between 512 to 2048 px (default 1024).", type=int, default=default_visionmaxres)
65796586
advparser.add_argument("--draftmodel", metavar=('[filename]'), help="Load a small draft model for speculative decoding. It will be fully offloaded. Vocab must match the main model.", default="")
65806587
advparser.add_argument("--draftamount", metavar=('[tokens]'), help="How many tokens to draft per chunk before verifying results", type=int, default=default_draft_amount)

0 commit comments

Comments
 (0)