Skip to content

Commit 15b325a

Browse files
committed
#155 利用していない処理を削除
1 parent 41e7719 commit 15b325a

File tree

5 files changed

+30
-105
lines changed

5 files changed

+30
-105
lines changed

package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,19 @@
3232
},
3333
"devDependencies": {
3434
"@eslint/eslintrc": "^3.3.3",
35-
"@eslint/js": "^9.39.1",
36-
"@types/node": "^24.10.1",
37-
"@typescript-eslint/eslint-plugin": "^8.48.1",
38-
"@typescript-eslint/parser": "^8.48.1",
39-
"@vitest/coverage-v8": "^4.0.15",
40-
"@vitest/web-worker": "^4.0.15",
41-
"eslint": "^9.39.1",
35+
"@eslint/js": "^9.39.2",
36+
"@types/node": "^25.0.9",
37+
"@typescript-eslint/eslint-plugin": "^8.53.0",
38+
"@typescript-eslint/parser": "^8.53.0",
39+
"@vitest/coverage-v8": "^4.0.17",
40+
"@vitest/web-worker": "^4.0.17",
41+
"eslint": "^9.39.2",
4242
"eslint-plugin-unused-imports": "^4.3.0",
43-
"globals": "^16.5.0",
44-
"jsdom": "^27.2.0",
43+
"globals": "^17.0.0",
44+
"jsdom": "^27.4.0",
4545
"typescript": "^5.9.3",
46-
"vite": "^7.2.6",
47-
"vitest": "^4.0.15",
46+
"vite": "^7.3.1",
47+
"vitest": "^4.0.17",
4848
"vitest-webgl-canvas-mock": "^1.1.0"
4949
},
5050
"peerDependencies": {

src/application/service/QueryStringParserService.test.ts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("QueryStringParserService", () =>
1616
it("parse query test case1", () =>
1717
{
1818
query.clear();
19-
query.set("test", 123);
19+
query.set("test", "123");
2020
expect(query.size).toBe(1);
2121

2222
const object: IQueryObject = execute();
@@ -48,9 +48,9 @@ describe("QueryStringParserService", () =>
4848

4949
const object: IQueryObject = execute("");
5050

51-
expect(query.size).toBe(2);
52-
expect(query.get("q")).toBe("abc");
53-
expect(query.get("sample")).toBe("1");
51+
expect(query.size).toBe(0);
52+
expect(query.has("q")).toBe(false);
53+
expect(query.has("sample")).toBe(false);
5454
expect(object.name).toBe("top");
5555
expect(object.queryString).toBe("?q=abc&sample=1");
5656
});
@@ -85,9 +85,9 @@ describe("QueryStringParserService", () =>
8585

8686
const object: IQueryObject = execute("");
8787

88-
expect(query.size).toBe(2);
89-
expect(query.get("q")).toBe("xyz");
90-
expect(query.get("sample")).toBe("0");
88+
expect(query.size).toBe(0);
89+
expect(query.has("q")).toBe(false);
90+
expect(query.has("sample")).toBe(false);
9191
expect(object.name).toBe("top");
9292
expect(object.queryString).toBe("?q=xyz&sample=0");
9393
});
@@ -124,9 +124,9 @@ describe("QueryStringParserService", () =>
124124

125125
const object: IQueryObject = execute("");
126126

127-
expect(query.size).toBe(2);
128-
expect(query.get("q")).toBe("xyz");
129-
expect(query.get("sample")).toBe("0");
127+
expect(query.size).toBe(0);
128+
expect(query.has("q")).toBe(false);
129+
expect(query.has("sample")).toBe(false);
130130
expect(object.name).toBe("quest/list");
131131
expect(object.queryString).toBe("?q=xyz&sample=0");
132132
});
@@ -163,9 +163,9 @@ describe("QueryStringParserService", () =>
163163

164164
const object: IQueryObject = execute("");
165165

166-
expect(query.size).toBe(2);
167-
expect(query.get("q")).toBe("xyz");
168-
expect(query.get("sample")).toBe("0");
166+
expect(query.size).toBe(0);
167+
expect(query.has("q")).toBe(false);
168+
expect(query.has("sample")).toBe(false);
169169
expect(object.name).toBe("top");
170170
expect(object.queryString).toBe("?q=xyz&sample=0");
171171
});
@@ -203,9 +203,9 @@ describe("QueryStringParserService", () =>
203203

204204
const object: IQueryObject = execute("");
205205

206-
expect(query.size).toBe(2);
207-
expect(query.get("q")).toBe("xyz");
208-
expect(query.get("sample")).toBe("0");
206+
expect(query.size).toBe(0);
207+
expect(query.has("q")).toBe(false);
208+
expect(query.has("sample")).toBe(false);
209209
expect(object.name).toBe("quest/detail");
210210
expect(object.queryString).toBe("?q=xyz&sample=0");
211211
});
@@ -218,9 +218,9 @@ describe("QueryStringParserService", () =>
218218

219219
const object: IQueryObject = execute("page/test?abc=123&xyz=999");
220220

221-
expect(query.size).toBe(2);
222-
expect(query.get("abc")).toBe("123");
223-
expect(query.get("xyz")).toBe("999");
221+
expect(query.size).toBe(0);
222+
expect(query.has("abc")).toBe(false);
223+
expect(query.has("xyz")).toBe(false);
224224
expect(object.name).toBe("page/test");
225225
expect(object.queryString).toBe("?abc=123&xyz=999");
226226
});

src/application/service/QueryStringParserService.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import type { IQueryObject } from "../../interface/IQueryObject";
22
import { $getConfig } from "../variable/Config";
33
import { query } from "../variable/Query";
4-
import { parseQueryString } from "../../shared/util/ParseQueryString";
54

65
/**
76
* @description 指定されたQueryStringか、URLのQueryStringをquery mapに登録
@@ -27,10 +26,6 @@ export const execute = (name: string = ""): IQueryObject =>
2726
let queryString = "";
2827
if (!name && location.search) {
2928
queryString = location.search;
30-
const parsed = parseQueryString(queryString);
31-
for (const [key, value] of parsed) {
32-
query.set(key, value);
33-
}
3429
}
3530

3631
const config = $getConfig();
@@ -62,10 +57,6 @@ export const execute = (name: string = ""): IQueryObject =>
6257
const questionIdx = name.indexOf("?");
6358
if (questionIdx > -1) {
6459
queryString = name.slice(questionIdx);
65-
const parsed = parseQueryString(name.slice(questionIdx + 1));
66-
for (const [key, value] of parsed) {
67-
query.set(key, value);
68-
}
6960
name = name.slice(0, questionIdx);
7061
}
7162

src/shared/util/ParseQueryString.test.ts

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/shared/util/ParseQueryString.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)