Skip to content

Commit 2935d3d

Browse files
committed
chore: change Resource struct field names from Request/Limit to Requests/Limits to align with Kubernetes resource naming conventions.
1 parent 345580f commit 2935d3d

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

api/v1/tensorfusionconnection_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ type Resource struct {
2727
}
2828

2929
type Resources struct {
30-
Request Resource `json:"request"`
31-
Limit Resource `json:"limit"`
30+
Requests Resource `json:"requests"`
31+
Limits Resource `json:"limits"`
3232
}
3333

3434
// TensorFusionConnectionSpec defines the desired state of TensorFusionConnection.

api/v1/zz_generated.deepcopy.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/controller/tensorfusionconnection_controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func (r *TensorFusionConnectionReconciler) Reconcile(ctx context.Context, req ct
9797
if connection.Status.Phase == "" || connection.Status.Phase == tfv1.TensorFusionConnectionPending {
9898
// Try to get an available node from scheduler
9999
var err error
100-
node, err = r.Scheduler.Schedule(connection.Spec.Resources.Request)
100+
node, err = r.Scheduler.Schedule(connection.Spec.Resources.Requests)
101101
if err != nil {
102102
log.Info(err.Error())
103103
connection.Status.Phase = tfv1.TensorFusionConnectionPending
@@ -138,7 +138,7 @@ func (r *TensorFusionConnectionReconciler) handleDeletion(ctx context.Context, c
138138
}
139139

140140
// Release the resources
141-
if err := r.Scheduler.Release(connection.Spec.Resources.Request, node); err != nil {
141+
if err := r.Scheduler.Release(connection.Spec.Resources.Requests, node); err != nil {
142142
return err
143143
}
144144

internal/webhook/v1/pod_webhook.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,11 @@ func generateTensorFusionConnection(pod *corev1.Pod, tfReq []TFReq) []*tfv1.Tens
207207
},
208208
Spec: tfv1.TensorFusionConnectionSpec{
209209
Resources: tfv1.Resources{
210-
Request: tfv1.Resource{
210+
Requests: tfv1.Resource{
211211
Tflops: req.Tflops,
212212
Vram: req.Vram,
213213
},
214-
Limit: tfv1.Resource{
214+
Limits: tfv1.Resource{
215215
Tflops: req.Tflops,
216216
Vram: req.Vram,
217217
},

0 commit comments

Comments
 (0)