Skip to content

Commit 2fea94a

Browse files
authored
fix: remove unused tf cluster fields, add PatchToEmbeddedWorkerContainer in client patch (#255)
1 parent 7248326 commit 2fea94a

16 files changed

+60
-460
lines changed

.vscode/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"cSpell.words": [
3+
"abcdefghijkmnopqrstuvwxy",
34
"admissionv",
45
"alertmanager",
56
"alertname",

api/v1/gpupool_types.go

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ type GPUPoolSpec struct {
3333

3434
NodeManagerConfig *NodeManagerConfig `json:"nodeManagerConfig,omitempty"`
3535

36-
// +optional
37-
ObservabilityConfig *ObservabilityConfig `json:"observabilityConfig,omitempty"`
38-
3936
// +optional
4037
QosConfig *QosConfig `json:"qosConfig,omitempty"`
4138

@@ -100,7 +97,7 @@ type NodeManagerConfig struct {
10097
NodePoolRollingUpdatePolicy *NodeRollingUpdatePolicy `json:"nodePoolRollingUpdatePolicy,omitempty"`
10198
}
10299

103-
// +kubebuilder:validation:Enum=Provisioned;AutoSelect
100+
// +kubebuilder:validation:Enum=Provisioned;AutoSelect;Karpenter
104101
type ProvisioningMode string
105102

106103
const (
@@ -228,23 +225,6 @@ type MaintenanceWindow struct {
228225
Includes []string `json:"includes,omitempty"`
229226
}
230227

231-
type ObservabilityConfig struct {
232-
// +optional
233-
Monitor *MonitorConfig `json:"monitor,omitempty"`
234-
235-
// +optional
236-
Alert *AlertConfig `json:"alert,omitempty"`
237-
}
238-
239-
type MonitorConfig struct {
240-
Interval string `json:"interval,omitempty"`
241-
}
242-
243-
type AlertConfig struct {
244-
// +optional
245-
Expression *runtime.RawExtension `json:"expression,omitempty"`
246-
}
247-
248228
// Define different QoS and their price.
249229
type QosConfig struct {
250230
Definitions []QosDefinition `json:"definitions,omitempty"`
@@ -339,6 +319,9 @@ type ClientConfig struct {
339319
// +optional
340320
PatchToContainer *runtime.RawExtension `json:"patchToContainer,omitempty"`
341321

322+
// +optional
323+
PatchToEmbeddedWorkerContainer *runtime.RawExtension `json:"patchToEmbeddedWorkerContainer,omitempty"`
324+
342325
// +optional
343326
PatchEmbeddedWorkerToPod *runtime.RawExtension `json:"patchEmbeddedWorkerToPod,omitempty"`
344327
}

api/v1/tensorfusioncluster_types.go

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"github.com/NexusGPU/tensor-fusion/internal/constants"
2121
"k8s.io/apimachinery/pkg/api/resource"
2222
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
23-
"k8s.io/apimachinery/pkg/runtime"
2423
)
2524

2625
// TensorFusionClusterSpec defines the desired state of TensorFusionCluster.
@@ -29,12 +28,6 @@ type TensorFusionClusterSpec struct {
2928

3029
// +optional
3130
ComputingVendor *ComputingVendorConfig `json:"computingVendor,omitempty"`
32-
33-
// +optional
34-
StorageVendor *StorageVendorConfig `json:"storageVendor,omitempty"`
35-
36-
// +optional
37-
DataPipelines *DataPipelinesConfig `json:"dataPipelines,omitempty"`
3831
}
3932

4033
// TensorFusionClusterStatus defines the observed state of TensorFusionCluster.
@@ -179,52 +172,6 @@ type ComputingVendorParams struct {
179172
ExtraParams map[string]string `json:"extraParams,omitempty"`
180173
}
181174

182-
// StorageVendorConfig defines Postgres database with extensions for timeseries storage and other resource aggregation results, system events and diagnostics reports etc.
183-
type StorageVendorConfig struct {
184-
Mode string `json:"mode,omitempty"` // Mode of the storage vendor (e.g., cloudnative-pg, timescale-db, RDS for PG).
185-
Image string `json:"image,omitempty"` // Image for the storage vendor (default to timescale).
186-
187-
// +optional
188-
InstallCloudNativePGOperator *bool `json:"installCloudNativePGOperator,omitempty"` // Whether to install CloudNative-PG operator.
189-
190-
StorageClass string `json:"storageClass,omitempty"` // Storage class for the storage vendor.
191-
PGExtensions []string `json:"pgExtensions,omitempty"` // List of PostgreSQL extensions to install.
192-
PGClusterTemplate runtime.RawExtension `json:"pgClusterTemplate,omitempty"` // Extra spec for the PostgreSQL cluster template.
193-
}
194-
195-
// DataPipelinesConfig defines the aggregation jobs that can make statistics on the data and then report to cloud if configured.
196-
type DataPipelinesConfig struct {
197-
Resources DataPipeline4ResourcesConfig `json:"resources,omitempty"`
198-
199-
Timeseries DataPipeline4TimeSeriesConfig `json:"timeseries,omitempty"`
200-
}
201-
202-
type DataPipeline4ResourcesConfig struct {
203-
// +optional
204-
SyncToCloud *bool `json:"syncToCloud,omitempty"` // Whether to sync resources to the cloud.
205-
206-
// +optional human readable time like 1h, 1d, default to 1h
207-
SyncPeriod string `json:"syncPeriod,omitempty"` // Period for syncing resources.
208-
}
209-
210-
type DataPipeline4TimeSeriesConfig struct {
211-
AggregationPeriods []string `json:"aggregationPeriods,omitempty"` // List of aggregation periods.
212-
RawDataRetention string `json:"rawDataRetention,omitempty"` // Retention period for raw data.
213-
AggregationDataRetention string `json:"aggregationDataRetention,omitempty"` // Retention period for aggregated data.
214-
RemoteWrite RemoteWriteConfig `json:"remoteWrite,omitempty"` // Configuration for remote write.
215-
}
216-
217-
// RemoteWriteConfig represents the configuration for remote write.
218-
type RemoteWriteConfig struct {
219-
Connection DataPipelineResultRemoteWriteConfig `json:"connection,omitempty"`
220-
Metrics []string `json:"metrics,omitempty"` // List of metrics to remote write.
221-
}
222-
223-
type DataPipelineResultRemoteWriteConfig struct {
224-
Type string `json:"type,omitempty"` // Type of the connection (e.g., datadog).
225-
URL string `json:"url,omitempty"` // URL of the connection.
226-
}
227-
228175
// +kubebuilder:object:root=true
229176
// +kubebuilder:subresource:status
230177
// +kubebuilder:resource:scope=Cluster

api/v1/zz_generated.deepcopy.go

Lines changed: 5 additions & 195 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)