fix(webhook): set pod namespace to 'default' if empty and add related tests (#155)

Author: 0x5457

internal/webhook/v1/pod_webhook.go

@@ -67,6 +67,10 @@ func (m *TensorFusionPodMutator) Handle(ctx context.Context, req admission.Reque
 		return admission.Errored(http.StatusBadRequest, err)
 	}
 
+	// Default namespace to 'default' if empty
+	if len(pod.Namespace) == 0 {
+		pod.Namespace = "default"
+	}
 	log := log.FromContext(ctx)
 	log.Info("Mutating pod", "generateName", pod.GenerateName, "namespace", pod.Namespace)
 

internal/webhook/v1/pod_webhook_test.go

@@ -60,6 +60,48 @@ var _ = Describe("TensorFusionPodMutator", func() {
 	})
 
 	Context("Handle", func() {
+		It("should handle pod with empty namespace and set workload.Namespace to 'default' (via Handle)", func() {
+			// Create a pod with empty namespace
+			pod := &corev1.Pod{
+				ObjectMeta: metav1.ObjectMeta{
+					Name: "test-pod-empty-ns",
+					// empty namespace
+					Namespace: "",
+					Labels: map[string]string{
+						constants.TensorFusionEnabledLabelKey: "true",
+					},
+					Annotations: map[string]string{
+						constants.GpuPoolKey:                "mock",
+						constants.InjectContainerAnnotation: "main",
+						constants.WorkloadKey:               "test-workload-empty-ns",
+						constants.GenWorkloadAnnotation:     "true",
+					},
+				},
+				Spec: corev1.PodSpec{
+					Containers: []corev1.Container{{
+						Name:  "main",
+						Image: "test-image",
+					}},
+				},
+			}
+			podBytes, err := json.Marshal(pod)
+			Expect(err).NotTo(HaveOccurred())
+
+			// Construct an admission request with the pod
+			req := admission.Request{
+				AdmissionRequest: admissionv1.AdmissionRequest{
+					Object: runtime.RawExtension{
+						Raw: podBytes,
+					},
+					Operation: admissionv1.Create,
+				},
+			}
+
+			// Call mutator.Handle to process the admission request
+			resp := mutator.Handle(ctx, req)
+			Expect(resp.Allowed).To(BeTrue())
+		})
+
 		It("should successfully mutate a pod with TF resources", func() {
 			// Set up a workload profile for testing
 			workloadProfile := &tfv1.WorkloadProfile{

internal/webhook/v1/tf_parser.go

@@ -32,7 +32,7 @@ type TensorFusionInfo struct {
 	GenWorkload     bool
 }
 
-func ParseTensorFusionInfo(ctx context.Context, k8sclient client.Client, pod *corev1.Pod) (TensorFusionInfo, error) {
+func ParseTensorFusionInfo(ctx context.Context, k8sClient client.Client, pod *corev1.Pod) (TensorFusionInfo, error) {
 	var info TensorFusionInfo
 	if pod.Annotations == nil {
 		return info, fmt.Errorf("no annotations found")
@@ -72,7 +72,7 @@ func ParseTensorFusionInfo(ctx context.Context, k8sclient client.Client, pod *co
 	workloadProfileName, ok := pod.Annotations[constants.WorkloadProfileAnnotation]
 	workloadProfile := &tfv1.WorkloadProfile{}
 	if ok {
-		if err := k8sclient.Get(ctx, client.ObjectKey{Name: workloadProfileName, Namespace: pod.Namespace}, workloadProfile); err != nil {
+		if err := k8sClient.Get(ctx, client.ObjectKey{Name: workloadProfileName, Namespace: pod.Namespace}, workloadProfile); err != nil {
 			return info, fmt.Errorf("get workload profile(%s) : %w", workloadProfileName, err)
 		}
 	}