fix: typo (#47)

Author: Code2Life

api/v1/gpu_types.go

@@ -55,9 +55,9 @@ const (
 // +kubebuilder:resource:scope=Cluster
 // +kubebuilder:printcolumn:name="GPU Model",type="string",JSONPath=".spec.gpuModel"
 // +kubebuilder:printcolumn:name="Phase",type="string",JSONPath=".status.phase"
-// +kubebuilder:printcolumn:name="Total TFlops",type="string",JSONPath=".status.capacity.flops"
+// +kubebuilder:printcolumn:name="Total TFlops",type="string",JSONPath=".status.capacity.tflops"
 // +kubebuilder:printcolumn:name="Total VRAM",type="string",JSONPath=".status.capacity.vram"
-// +kubebuilder:printcolumn:name="Available TFlops",type="string",JSONPath=".status.available.flops"
+// +kubebuilder:printcolumn:name="Available TFlops",type="string",JSONPath=".status.available.tflops"
 // +kubebuilder:printcolumn:name="Available VRAM",type="string",JSONPath=".status.available.vram"
 // +kubebuilder:printcolumn:name="Device UUID",type="string",JSONPath=".status.uuid"
 // GPU is the Schema for the gpus API.

charts/tensor-fusion/crds/tensor-fusion.ai_gpus.yaml

@@ -21,13 +21,13 @@ spec:
     - jsonPath: .status.phase
       name: Phase
       type: string
-    - jsonPath: .status.capacity.flops
+    - jsonPath: .status.capacity.tflops
       name: Total TFlops
       type: string
     - jsonPath: .status.capacity.vram
       name: Total VRAM
       type: string
-    - jsonPath: .status.available.flops
+    - jsonPath: .status.available.tflops
       name: Available TFlops
       type: string
     - jsonPath: .status.available.vram

config/crd/bases/tensor-fusion.ai_gpus.yaml

@@ -21,13 +21,13 @@ spec:
     - jsonPath: .status.phase
       name: Phase
       type: string
-    - jsonPath: .status.capacity.flops
+    - jsonPath: .status.capacity.tflops
       name: Total TFlops
       type: string
     - jsonPath: .status.capacity.vram
       name: Total VRAM
       type: string
-    - jsonPath: .status.available.flops
+    - jsonPath: .status.available.tflops
       name: Available TFlops
       type: string
     - jsonPath: .status.available.vram

internal/controller/node_controller.go

@@ -102,23 +102,16 @@ func (r *NodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 		// Skip creation if the GPUNode already exists
 		gpuNode := &tfv1.GPUNode{}
 		if err := r.Client.Get(ctx, client.ObjectKey{Name: node.Name}, gpuNode); err != nil {
-			if errors.IsNotFound(err) || gpuNode.Status.KubernetesNodeName == "" {
-				newGPUNode := r.generateGPUNode(node, pool)
+			if errors.IsNotFound(err) {
+				gpuNode = r.generateGPUNode(node, pool)
 				// Set owner reference to cascade delete after GPU node created
-				if err := controllerutil.SetControllerReference(node, newGPUNode, r.Scheme); err != nil {
+				if err := controllerutil.SetControllerReference(node, gpuNode, r.Scheme); err != nil {
 					return ctrl.Result{}, fmt.Errorf("failed to set controller reference: %w", err)
 				}
-				_, e := controllerutil.CreateOrUpdate(ctx, r.Client, newGPUNode, nil)
+				_, e := controllerutil.CreateOrUpdate(ctx, r.Client, gpuNode, nil)
 				if e != nil {
 					return ctrl.Result{}, fmt.Errorf("failed to create or patch GPUNode: %w", e)
 				}
-
-				newGPUNode.InitializeStatus(resource.Quantity{}, resource.Quantity{}, 0)
-				newGPUNode.Status.KubernetesNodeName = node.Name
-				if err := r.Client.Status().Update(ctx, newGPUNode); err != nil {
-					return ctrl.Result{}, fmt.Errorf("can not add Kubernetes Node info into gpuNode(%s) status : %w", newGPUNode.Name, err)
-				}
-				log.Info("Created GPUNode due to selector matched", "name", newGPUNode.Name)
 			}
 		} else {
 			// GPUNode resource already exists, indicate node has been changed
@@ -129,6 +122,15 @@ func (r *NodeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 				return ctrl.Result{}, fmt.Errorf("can not update gpuNode(%s) annotation : %w", gpuNode.Name, err)
 			}
 		}
+
+		if gpuNode.Status.KubernetesNodeName == "" {
+			gpuNode.InitializeStatus(resource.Quantity{}, resource.Quantity{}, 0)
+			gpuNode.Status.KubernetesNodeName = node.Name
+			if err := r.Client.Status().Update(ctx, gpuNode); err != nil {
+				return ctrl.Result{}, fmt.Errorf("can not add Kubernetes Node info into gpuNode(%s) status : %w", gpuNode.Name, err)
+			}
+			log.Info("Created GPUNode due to selector matched", "name", gpuNode.Name)
+		}
 	}
 
 	return ctrl.Result{}, nil