Remove phpExecutable as setPhpExecutable() is now deprecated in upstream

Author: paulbalandan

README.md

@@ -150,7 +150,6 @@ containing your desired options.
 | hideProgress   | `bool`                                   | `false`                              |
 | indent         | `string`                                 | `'    '` // 4 spaces                 |
 | lineEnding     | `string`                                 | `"\n"`                               |
-| phpExecutable  | `null, string`                           | `null`                               |
 | isRiskyAllowed | `bool`                                   | `false`                              |
 | usingCache     | `bool`                                   | `true`                               |
 | customRules    | `array`                                  | `[]`                                 |

src/Factory.php

@@ -34,7 +34,6 @@ final class Factory
      *     hideProgress: bool,
      *     indent: non-empty-string,
      *     lineEnding: non-empty-string,
-     *     phpExecutable: null|string,
      *     isRiskyAllowed: bool,
      *     usingCache: bool,
      *     rules: array<string, array<string, mixed>|bool>
@@ -55,7 +54,6 @@ private function __construct(private RulesetInterface $ruleset, private array $o
      *     hideProgress?: bool,
      *     indent?: non-empty-string,
      *     lineEnding?: non-empty-string,
-     *     phpExecutable?: null|string,
      *     isRiskyAllowed?: bool,
      *     usingCache?: bool,
      *     customRules?: array<string, array<string, mixed>|bool>
@@ -90,7 +88,6 @@ public static function create(RulesetInterface $ruleset, array $overrides = [],
         $options['hideProgress'] ??= false;
         $options['indent'] ??= '    ';
         $options['lineEnding'] ??= "\n";
-        $options['phpExecutable'] ??= null;
         $options['isRiskyAllowed'] ??= $ruleset->willAutoActivateIsRiskyAllowed();
         $options['usingCache'] ??= true;
         $options['rules'] = array_merge($ruleset->getRules(), $overrides, $options['customRules'] ?? []);
@@ -168,7 +165,6 @@ private function invoke(array $overrides = []): ConfigInterface
             ->setHideProgress($this->options['hideProgress'])
             ->setIndent($this->options['indent'])
             ->setLineEnding($this->options['lineEnding'])
-            ->setPhpExecutable($this->options['phpExecutable'])
             ->setRiskyAllowed($this->options['isRiskyAllowed'])
             ->setUsingCache($this->options['usingCache'])
             ->setRules($rules)

tests/FactoryTest.php

@@ -85,7 +85,6 @@ public function testFactoryReturnsDefaultOptionsWhenNoOptionsGiven(): void
         self::assertFalse($config->getHideProgress());
         self::assertSame('    ', $config->getIndent());
         self::assertSame("\n", $config->getLineEnding());
-        self::assertNull($config->getPhpExecutable());
         self::assertFalse($config->getRiskyAllowed());
         self::assertTrue($config->getUsingCache());
     }
@@ -98,7 +97,6 @@ public function testFactoryConsumesPassedOptionsToIt(): void
             'hideProgress' => true,
             'indent' => "\t",
             'lineEnding' => "\r\n",
-            'phpExecutable' => PHP_BINARY,
             'usingCache' => false,
         ];
         $config = Factory::create($this->mockRuleset(), [], $options)->forProjects();
@@ -108,7 +106,6 @@ public function testFactoryConsumesPassedOptionsToIt(): void
         self::assertTrue($config->getHideProgress());
         self::assertSame($options['indent'], $config->getIndent());
         self::assertSame($options['lineEnding'], $config->getLineEnding());
-        self::assertSame($options['phpExecutable'], $config->getPhpExecutable());
         self::assertFalse($config->getUsingCache());
     }