Disallow dynamic calls to static methods

Author: paulbalandan

src/Ruleset/Nexus73.php

@@ -291,7 +291,7 @@ public function __construct()
             'php_unit_size_class'                           => false,
             'php_unit_strict'                               => true, // risky
             'php_unit_test_annotation'                      => false, // risky
-            'php_unit_test_case_static_method_calls'        => ['call_type' => 'this'], // risky
+            'php_unit_test_case_static_method_calls'        => ['call_type' => 'self'], // risky
             'php_unit_test_class_requires_covers'           => false,
             'phpdoc_add_missing_param_annotation'           => ['only_untyped' => false],
             'phpdoc_align'                                  => true,

src/Test/AbstractRulesetTestCase.php

@@ -52,7 +52,7 @@ final public function testAllConfiguredRulesAreBuiltIn(): void
         sort($fixersNotBuiltIn);
         $c = \count($fixersNotBuiltIn);
 
-        $this->assertEmpty($fixersNotBuiltIn, sprintf(
+        self::assertEmpty($fixersNotBuiltIn, sprintf(
             'Failed asserting that %s for the %s "%s" %s built-in to PhpCsFixer.',
             $c > 1 ? 'fixers' : 'fixer',
             $c > 1 ? 'rules' : 'rule',
@@ -74,7 +74,7 @@ final public function testRulesAreSortedByName(string $source, array $rules): vo
         $sorted = $rules;
         sort($sorted);
 
-        $this->assertSame($sorted, $rules, sprintf(
+        self::assertSame($sorted, $rules, sprintf(
             'Failed asserting that the rules in "%s" are sorted by name.',
             $source
         ));
@@ -90,7 +90,7 @@ final public function testAllBuiltInRulesAreConfigured(): void
         sort($fixersWithoutConfiguration);
         $c = \count($fixersWithoutConfiguration);
 
-        $this->assertEmpty($fixersWithoutConfiguration, sprintf(
+        self::assertEmpty($fixersWithoutConfiguration, sprintf(
             'Failed asserting that built-in %s for the %s "%s" %s configured in this ruleset.',
             $c > 1 ? 'fixers' : 'fixer',
             $c > 1 ? 'rules' : 'rule',
@@ -103,8 +103,8 @@ final public function testHeaderCommentFixerIsDisabledByDefault(): void
     {
         $rules = self::createRuleset()->getRules();
 
-        $this->assertArrayHasKey('header_comment', $rules);
-        $this->assertFalse($rules['header_comment']);
+        self::assertArrayHasKey('header_comment', $rules);
+        self::assertFalse($rules['header_comment']);
     }
 
     /**

strict-rules.neon.dist

@@ -1,5 +1,5 @@
 # From phpstan/phpstan-strict-rules
-# but removed overly strict rules
+# but commented overly strict rules
 
 parameters:
 	polluteScopeWithLoopInitialAssignments: false
@@ -23,6 +23,7 @@ rules:
 	- PHPStan\Rules\Classes\RequireParentConstructCallRule
 	- PHPStan\Rules\DisallowedConstructs\DisallowedEmptyRule
 	- PHPStan\Rules\DisallowedConstructs\DisallowedImplicitArrayCreationRule
+	# - PHPStan\Rules\DisallowedConstructs\DisallowedShortTernaryRule
 	- PHPStan\Rules\ForeachLoop\OverwriteVariablesWithForeachRule
 	- PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule
 	- PHPStan\Rules\Operators\OperandInArithmeticPostDecrementRule
@@ -35,6 +36,7 @@ rules:
 	- PHPStan\Rules\Operators\OperandsInArithmeticModuloRule
 	- PHPStan\Rules\Operators\OperandsInArithmeticMultiplicationRule
 	- PHPStan\Rules\Operators\OperandsInArithmeticSubtractionRule
+	- PHPStan\Rules\StrictCalls\DynamicCallOnStaticMethodsRule
 	- PHPStan\Rules\StrictCalls\StrictFunctionCallsRule
 	- PHPStan\Rules\SwitchConditions\MatchingTypeInSwitchCaseConditionRule
 	- PHPStan\Rules\VariableVariables\VariableMethodCallRule

tests/FactoryTest.php

@@ -44,45 +44,45 @@ public function testFactoryThrowsExceptionOnIncompatibleVersionId(): void
     public function testFactoryReturnsInstanceOfConfig(): void
     {
         $config = Factory::create($this->mockRuleset())->forProjects();
-        $this->assertInstanceOf('PhpCsFixer\Config', $config);
+        self::assertInstanceOf('PhpCsFixer\Config', $config);
 
         $config = Factory::create($this->mockRuleset())->forLibrary('Library', 'John Doe', 'email', 2020);
-        $this->assertInstanceOf('PhpCsFixer\Config', $config);
+        self::assertInstanceOf('PhpCsFixer\Config', $config);
     }
 
     public function testFactoryPassesSameRulesFromRuleset(): void
     {
         $ruleset = $this->mockRuleset();
         $config = Factory::create($ruleset)->forProjects();
 
-        $this->assertSame($ruleset->getRules(), $config->getRules());
+        self::assertSame($ruleset->getRules(), $config->getRules());
     }
 
     public function testFactoryAllowsOverrideOfRules(): void
     {
         $config = Factory::create(new Nexus73())->forProjects();
-        $this->assertIsArray($config->getRules()['binary_operator_spaces']);
+        self::assertIsArray($config->getRules()['binary_operator_spaces']);
 
         $config = Factory::create(new Nexus73(), [
             'binary_operator_spaces' => false,
         ])->forProjects();
-        $this->assertFalse($config->getRules()['binary_operator_spaces']);
+        self::assertFalse($config->getRules()['binary_operator_spaces']);
     }
 
     public function testFactoryReturnsDefaultOptionsWhenNoOptionsGiven(): void
     {
         $config = Factory::create($this->mockRuleset())->forProjects();
 
-        $this->assertSame('.php_cs.cache', $config->getCacheFile());
-        $this->assertSame([], $config->getCustomFixers());
-        $this->assertInstanceOf('PhpCsFixer\Finder', $config->getFinder());
-        $this->assertSame('txt', $config->getFormat());
-        $this->assertFalse($config->getHideProgress());
-        $this->assertSame('    ', $config->getIndent());
-        $this->assertSame("\n", $config->getLineEnding());
-        $this->assertNull($config->getPhpExecutable());
-        $this->assertIsBool($config->getRiskyAllowed());
-        $this->assertTrue($config->getUsingCache());
+        self::assertSame('.php_cs.cache', $config->getCacheFile());
+        self::assertSame([], $config->getCustomFixers());
+        self::assertInstanceOf('PhpCsFixer\Finder', $config->getFinder());
+        self::assertSame('txt', $config->getFormat());
+        self::assertFalse($config->getHideProgress());
+        self::assertSame('    ', $config->getIndent());
+        self::assertSame("\n", $config->getLineEnding());
+        self::assertNull($config->getPhpExecutable());
+        self::assertIsBool($config->getRiskyAllowed());
+        self::assertTrue($config->getUsingCache());
     }
 
     public function testFactoryConsumesPassedOptionsToIt(): void
@@ -98,22 +98,22 @@ public function testFactoryConsumesPassedOptionsToIt(): void
         ];
         $config = Factory::create($this->mockRuleset(), [], $options)->forProjects();
 
-        $this->assertSame($options['cacheFile'], $config->getCacheFile());
-        $this->assertSame($options['format'], $config->getFormat());
-        $this->assertTrue($config->getHideProgress());
-        $this->assertSame($options['indent'], $config->getIndent());
-        $this->assertSame($options['lineEnding'], $config->getLineEnding());
-        $this->assertSame($options['phpExecutable'], $config->getPhpExecutable());
-        $this->assertFalse($config->getUsingCache());
+        self::assertSame($options['cacheFile'], $config->getCacheFile());
+        self::assertSame($options['format'], $config->getFormat());
+        self::assertTrue($config->getHideProgress());
+        self::assertSame($options['indent'], $config->getIndent());
+        self::assertSame($options['lineEnding'], $config->getLineEnding());
+        self::assertSame($options['phpExecutable'], $config->getPhpExecutable());
+        self::assertFalse($config->getUsingCache());
     }
 
     public function testCreateForLibraryCreatesPreformattedLicense(): void
     {
         $config = Factory::create($this->mockRuleset())->forLibrary('Library', 'Foo Bar', '[email protected]', 2020);
         $header = $config->getRules()['header_comment']['header'];
 
-        $this->assertStringContainsString('This file is part of Library.', $header);
-        $this->assertStringContainsString('(c) 2020 Foo Bar <[email protected]>', $header);
+        self::assertStringContainsString('This file is part of Library.', $header);
+        self::assertStringContainsString('(c) 2020 Foo Bar <[email protected]>', $header);
     }
 
     /**