Add testing for deprecated fixers

Author: paulbalandan

src/Ruleset/Nexus73.php

@@ -112,7 +112,7 @@ public function __construct()
             'final_class'                            => false, // risky
             'final_internal_class'                   => true, // risky
             'final_public_method_for_abstract_class' => false, // risky
-            'final_static_access'                    => true,
+            'final_static_access'                    => false, // deprecated
             'fopen_flag_order'                       => true, // risky
             'fopen_flags'                            => ['b_mode' => true], // risky
             'full_opening_tag'                       => true,
@@ -308,7 +308,7 @@ public function __construct()
             'php_unit_mock_short_will_return'               => true, // risky
             'php_unit_namespaced'                           => true, // risky
             'php_unit_no_expectation_annotation'            => true, // risky
-            'php_unit_ordered_covers'                       => true,
+            'php_unit_ordered_covers'                       => false, // deprecated
             'php_unit_set_up_tear_down_visibility'          => true, // risky
             'php_unit_size_class'                           => false,
             'php_unit_strict'                               => true, // risky
@@ -328,7 +328,7 @@ public function __construct()
             'phpdoc_no_package'                             => true,
             'phpdoc_no_useless_inheritdoc'                  => true,
             'phpdoc_order'                                  => true,
-            'phpdoc_order_by_value'                         => false,
+            'phpdoc_order_by_value'                         => true,
             'phpdoc_return_self_reference'                  => true,
             'phpdoc_scalar'                                 => true,
             'phpdoc_separation'                             => true,
@@ -349,7 +349,7 @@ public function __construct()
             'pre_increment'                                 => false, // deprecated
             'protected_to_private'                          => true,
             'psr0'                                          => false,
-            'psr4'                                          => true, // deprecated
+            'psr4'                                          => false, // deprecated
             'psr_autoloading'                               => ['dir' => null],
             'random_api_migration'                          => true,
             'regular_callable_call'                         => true, // risky

src/Test/AbstractRulesetTestCase.php

@@ -14,9 +14,10 @@
 namespace Nexus\CsConfig\Test;
 
 use Nexus\CsConfig\Ruleset\RulesetInterface;
+use PhpCsFixer\Fixer\DeprecatedFixerInterface;
 use PhpCsFixer\Fixer\FixerInterface;
 use PhpCsFixer\FixerFactory;
-use PhpCsFixer\RuleSet;
+use PhpCsFixer\RuleSet\RuleSet;
 use PHPUnit\Framework\TestCase;
 
 abstract class AbstractRulesetTestCase extends TestCase
@@ -29,10 +30,36 @@ abstract class AbstractRulesetTestCase extends TestCase
     final public static function ruleNamesProvider(): iterable
     {
         $ruleset = static::createRuleset();
+        $name = $ruleset->getName();
 
-        return [
-            [$ruleset->getName(), array_keys($ruleset->getRules())],
-        ];
+        yield $name => [$name, array_keys($ruleset->getRules())];
+    }
+
+    /**
+     * @codeCoverageIgnore
+     *
+     * @return iterable
+     */
+    public static function deprecatedBuiltInFixersProvider(): iterable
+    {
+        static $deprecatedFixers;
+
+        if (null === $deprecatedFixers) {
+            $fixerFactory = FixerFactory::create();
+            $fixerFactory->registerBuiltInFixers();
+
+            $deprecatedFixers = array_map(static function (FixerInterface $fixer): string {
+                return $fixer->getName();
+            }, array_filter($fixerFactory->getFixers(), static function (FixerInterface $fixer): bool {
+                return $fixer instanceof DeprecatedFixerInterface;
+            }));
+
+            sort($deprecatedFixers);
+        }
+
+        foreach ($deprecatedFixers as $fixer) {
+            yield $fixer => [$fixer];
+        }
     }
 
     protected static function createRuleset(): RulesetInterface
@@ -107,6 +134,28 @@ final public function testHeaderCommentFixerIsDisabledByDefault(): void
         self::assertFalse($rules['header_comment']);
     }
 
+    /**
+     * @dataProvider deprecatedBuiltInFixersProvider
+     *
+     * @param string $fixer
+     *
+     * @return void
+     */
+    final public function testDeprecatedFixersAreTurnedOff(string $fixer): void
+    {
+        static $rules;
+
+        if (null === $rules) {
+            $rules = self::createRuleset()->getRules();
+        }
+
+        self::assertArrayHasKey($fixer, $rules);
+        self::assertFalse($rules[$fixer], sprintf(
+            'Failed asserting that the deprecated "%s" fixer is set to false.',
+            $fixer
+        ));
+    }
+
     /**
      * Rules defined by PhpCsFixer.
      *
@@ -139,6 +188,6 @@ private function configuredFixers(): array
             return true;
         }, static::createRuleset()->getRules());
 
-        return array_keys(RuleSet::create($rules)->getRules());
+        return array_keys((new RuleSet($rules))->getRules());
     }
 }