Predicate scripts should be invovked asynchronously

Author: Nfactor26

src/Pixel.Automation.Core.Components/Entities/ControlEntity.cs

@@ -203,8 +203,8 @@ protected T GetElementMatchingCriteria<T>(IEnumerable<T> foundControls)
         protected async Task<bool> ApplyPredicate<T>(string predicateScriptFile, T targetElement)
         {
             IScriptEngine scriptEngine = this.EntityManager.GetScriptEngine();
-            var fn = await scriptEngine.CreateDelegateAsync<Func<IComponent, T, bool>>(predicateScriptFile);
-            bool isMatch = fn(this, targetElement);
+            var fn = await scriptEngine.CreateDelegateAsync<Func<IComponent, T, Task<bool>>>(predicateScriptFile);
+            bool isMatch = await fn(this, targetElement);
             return isMatch;
         }
     }

src/Pixel.Automation.Core/Arguments/ArgumentExtensions.cs

@@ -15,8 +15,8 @@ public static class ArgumentExtensions
         private static readonly string setValueAction = "return ((Action<{0}>)SetValue);";
         private static readonly string getValueTemplate = "{0} GetValue(){1}{{{1}    return default;{1}}}";
         private static readonly string getValueDelegate = "return ((Func<{0}>)GetValue);";
-        private static readonly string predicateScriptTemplate = "bool IsMatch(IComponent current, {0} argument){1}{{{1}    return false;{1}}}";
-        private static readonly string predicateDelegate = "return ((Func<IComponent, {0}, bool>)IsMatch);";
+        private static readonly string predicateScriptTemplate = "Task<bool> IsMatch(IComponent current, {0} argument){1}{{{1}    return Task.FromResult(false);{1}}}";
+        private static readonly string predicateDelegate = "return ((Func<IComponent, {0}, Task<bool>>)IsMatch);";
 
         /// <summary>
         /// Get the value of the argument

src/Pixel.Automation.Window.Management.Components/FindChildWindowActorComponent.cs

@@ -162,10 +162,8 @@ public override async Task ActAsync()
         protected async Task<bool> ApplyPredicate(string predicateScriptFile, ApplicationWindow applicationWindow)
         {
             IScriptEngine scriptEngine = this.EntityManager.GetScriptEngine();
-
-            var fn = await scriptEngine.CreateDelegateAsync<Func<Core.Interfaces.IComponent, ApplicationWindow, bool>>(predicateScriptFile);
-
-            bool isMatch = fn(this, applicationWindow);
+            var fn = await scriptEngine.CreateDelegateAsync<Func<Core.Interfaces.IComponent, ApplicationWindow, Task<bool>>>(predicateScriptFile);
+            bool isMatch = await fn(this, applicationWindow);
             return isMatch;
 
         }

src/Pixel.Automation.Window.Management.Components/FindDesktopWindowActorComponent.cs

@@ -73,7 +73,7 @@ public FilterMode FilterMode
                         this.SetDispalyAttribute(nameof(Index), true);
                         break;
                     case FilterMode.Custom:
-                        this.Filter = new PredicateArgument<ApplicationWindow>();
+                        this.Filter = new PredicateArgument<ApplicationWindow>() { CanChangeType = false };
                         this.SetDispalyAttribute(nameof(Filter), true);
                         this.SetDispalyAttribute(nameof(Index), false);
                         break;
@@ -154,9 +154,8 @@ public override async Task ActAsync()
         protected async Task<bool> ApplyPredicate(string predicateScriptFile, ApplicationWindow applicationWindow)
         {
             IScriptEngine scriptEngine = this.EntityManager.GetScriptEngine();
-            var fn = await scriptEngine.CreateDelegateAsync<Func<Core.Interfaces.IComponent, ApplicationWindow, bool>>(predicateScriptFile);
-
-            bool isMatch = fn(this, applicationWindow);
+            var fn = await scriptEngine.CreateDelegateAsync<Func<Core.Interfaces.IComponent, ApplicationWindow, Task<bool>>>(predicateScriptFile);
+            bool isMatch = await fn(this, applicationWindow);
             return isMatch;
         }
     }

src/Unit.Tests/Pixel.Automation.Core.Tests/Arguments/ArgumentExtensionsFixture.cs

@@ -22,13 +22,13 @@ public async Task ValidateThatValueCanBeRetrievedFromAnArgumentUsingGetValueExte
         }
 
         [Test]
-        public void ValidatethatArgumentValueCanBeSetUsingSetValueExtensionMethod()
+        public async Task ValidatethatArgumentValueCanBeSetUsingSetValueExtensionMethod()
         {
             var argument = new InArgument<int>();
             var argumentProcessor = Substitute.For<IArgumentProcessor>();
             argumentProcessor.When(x => x.SetValueAsync<int>(Arg.Any<Argument>(), Arg.Any<int>())).Do(x => argument.DefaultValue = x.ArgAt<int>(1));
 
-            argument.SetValue(argumentProcessor, 10);
+            await argument.SetValue(argumentProcessor, 10);
 
             Assert.AreEqual(10, argument.DefaultValue);
 
@@ -58,7 +58,7 @@ public void ValidateThatInitialScriptCanBeGeneratedForOutArgument()
         public void ValidateThatInitialScriptCanBeGeneratedForPredicateArgument()
         {
             var argument = new PredicateArgument<int>();
-            var expected = "using System;\r\nusing Pixel.Automation.Core.Interfaces;\r\nbool IsMatch(IComponent current, Int32 argument)\r\n{\r\n    return false;\r\n}\r\nreturn ((Func<IComponent, Int32, bool>)IsMatch);";
+            var expected = "using System;\r\nusing Pixel.Automation.Core.Interfaces;\r\nTask<bool> IsMatch(IComponent current, Int32 argument)\r\n{\r\n    return Task.FromResult(false);\r\n}\r\nreturn ((Func<IComponent, Int32, Task<bool>>)IsMatch);";
             var result = argument.GenerateInitialScript();
 
             Assert.AreEqual(expected, result);

src/Unit.Tests/Pixel.Automation.Window.Management.Components.Tests/FindChildWindowActorComponentFixture.cs

@@ -122,14 +122,14 @@ public async Task ValidateThatFindChildWindowActorCanLocateChildWindowByCustomFi
             argumentProcessor.GetValueAsync<ApplicationWindow>(Arg.Any<InArgument<ApplicationWindow>>()).Returns(parentWindow);
 
             var scriptEngine = Substitute.For<IScriptEngine>();
-            scriptEngine.CreateDelegateAsync<Func<IComponent, ApplicationWindow, bool>>(Arg.Any<string>())
+            scriptEngine.CreateDelegateAsync<Func<IComponent, ApplicationWindow, Task<bool>>>(Arg.Any<string>())
                 .Returns((c, a) =>
                 {
                     if(a.Equals(childWindowTwo))
                     {
-                        return true;
+                        return Task.FromResult(true);
                     }
-                    return false;
+                    return Task.FromResult(false);
                 });
 
             entityManager.GetArgumentProcessor().Returns(argumentProcessor);
@@ -156,7 +156,7 @@ public async Task ValidateThatFindChildWindowActorCanLocateChildWindowByCustomFi
             await argumentProcessor.Received(1).GetValueAsync<string>(Arg.Any<InArgument<string>>());
             await argumentProcessor.Received(1).GetValueAsync<ApplicationWindow>(Arg.Any<InArgument<ApplicationWindow>>());
             windowManager.Received(1).FindAllChildWindows(parentWindow, childWindowTitle, MatchType.Equals, true);
-            await scriptEngine.Received(2).CreateDelegateAsync<Func<IComponent, ApplicationWindow, bool>>("FindWindow.csx"); // 1 for each window in collecton until match found
+            await scriptEngine.Received(2).CreateDelegateAsync<Func<IComponent, ApplicationWindow, Task<bool>>>("FindWindow.csx"); // 1 for each window in collecton until match found
             await argumentProcessor.Received(1).SetValueAsync<ApplicationWindow>(Arg.Any<OutArgument<ApplicationWindow>>(), childWindowTwo);
         }
     }

src/Unit.Tests/Pixel.Automation.Window.Management.Components.Tests/FindDesktopWindowActorComponentFixture.cs

@@ -118,14 +118,14 @@ public async Task ValidateThatFindChildWindowActorCanLocateChildWindowByCustomFi
             argumentProcessor.GetValueAsync<string>(Arg.Any<InArgument<string>>()).Returns(windowTitle);
 
             var scriptEngine = Substitute.For<IScriptEngine>();
-            scriptEngine.CreateDelegateAsync<Func<IComponent, ApplicationWindow, bool>>(Arg.Any<string>())
+            scriptEngine.CreateDelegateAsync<Func<IComponent, ApplicationWindow, Task<bool>>>(Arg.Any<string>())
                 .Returns((c, a) =>
                 {
                     if (a.Equals(windowTwo))
                     {
-                        return true;
+                        return Task.FromResult(true);
                     }
-                    return false;
+                    return Task.FromResult(false);
                 });
 
             entityManager.GetArgumentProcessor().Returns(argumentProcessor);
@@ -150,7 +150,7 @@ public async Task ValidateThatFindChildWindowActorCanLocateChildWindowByCustomFi
 
             await argumentProcessor.Received(1).GetValueAsync<string>(Arg.Any<InArgument<string>>());
             windowManager.Received(1).FindAllDesktopWindows(windowTitle, MatchType.Equals, true);
-            await scriptEngine.Received(2).CreateDelegateAsync<Func<IComponent, ApplicationWindow, bool>>("FindWindow.csx"); // 1 for each window in collecton until match found
+            await scriptEngine.Received(2).CreateDelegateAsync<Func<IComponent, ApplicationWindow, Task<bool>>>("FindWindow.csx"); // 1 for each window in collecton until match found
             await argumentProcessor.Received(1).SetValueAsync<ApplicationWindow>(Arg.Any<OutArgument<ApplicationWindow>>(), windowTwo);