Skip to content

Commit fe42aad

Browse files
authored
Fix build issues with on demand workflow for pixel designer and pixel runner (#208)
* Fix build issues with on demand workflow for pixel designer and pixel runner 1. For linux-x64 , build pixel runner on windows-latest os. We are getting an error while building on linux-latest - error NETSDK1100: To build a project targeting Windows on this operating system, set the EnableWindowsTargeting property to true. We could build on linux-latest by passisng /p:EnableWindowsTargeting to true alternatively. 2. Fixed artifiact path for designer and runner * correct artifact name
1 parent f2e1c8e commit fe42aad

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/build-pixel-designer.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,5 @@ jobs:
7373
- name: Upload pixel-designer artifacts
7474
uses: actions/upload-artifact@v3
7575
with:
76-
name: pixel-designer-${{ matrix.os }}
77-
path: .builds/release/designer/${{ inputs.target-runtime }}
76+
name: pixel-designer-${{ inputs.target-os }}
77+
path: .builds/release/designer/${{ inputs.target-framework }}/${{ inputs.target-runtime }}

.github/workflows/build-pixel-runner.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,5 @@ jobs:
7373
- name: Upload pixel-runner artifacts
7474
uses: actions/upload-artifact@v3
7575
with:
76-
name: pixel-runner-${{ matrix.os }}
77-
path: .builds/release/runner/${{ inputs.target-runtime }}
76+
name: pixel-runner-${{ inputs.target-os }}
77+
path: .builds/release/runner/${{ inputs.target-framework }}/${{ inputs.target-runtime }}

.github/workflows/on-demand-build-with-artifact.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
build-pixel-runner-for-linux-x64:
2828
uses: ./.github/workflows/build-pixel-runner.yml
2929
with:
30-
target-os: ubuntu-latest
30+
target-os: windows-latest
3131
target-runtime: linux-x64
3232
target-framework: net6.0
3333
self-contained: false

0 commit comments

Comments
 (0)