feat: Add Traditional Chinese (zh-TW) locale support with complete translations #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored frontend/src/locale/src/tw.json to use the required ICU MessageFormat structure (objects with "defaultMessage"). Changes include: 1. Added the missing "language-name" key at the top level to fix the build error. 2. Converted all simple string values to objects containing "defaultMessage". 3. Aligned keys with the existing zh.json and en.json files. This resolves the "TypeError: Cannot read properties of undefined (reading 'length')" error in the CI check.
|
Docker Image for build 3 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
Member
|
Can you please rebase and resolve conflicts? I would do it for you, but..
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR adds complete Traditional Chinese (Taiwan) locale support to Nginx Proxy Manager, including UI translations and help documentation.
🎯 Changes
New Files Added
frontend/src/locale/src/tw.json(171 translation entries)frontend/src/locale/src/HelpDoc/tw/AccessLists.mdfrontend/src/locale/src/HelpDoc/tw/Certificates.mdfrontend/src/locale/src/HelpDoc/tw/DeadHosts.mdfrontend/src/locale/src/HelpDoc/tw/ProxyHosts.mdfrontend/src/locale/src/HelpDoc/tw/RedirectionHosts.mdfrontend/src/locale/src/HelpDoc/tw/Streams.mdfrontend/src/locale/src/HelpDoc/tw/index.tsModified Files
frontend/check-locales.cjs- Addedtwlocale configurationfrontend/src/locale/IntlProvider.tsx- Registered Traditional Chinese localefrontend/src/locale/src/HelpDoc/index.ts- Registeredtwhelp documentationfrontend/src/locale/src/lang-list. json- Added locale display name🌐 Locale Details
twzh-TWTW(Taiwan)✨ Features
✅ Complete UI translation in Traditional Chinese
✅ All help documentation translated
✅ Proper flag icon mapping (Taiwan flag)
✅ Follows existing locale implementation pattern
✅ No breaking changes to existing code
✅ Maintains backward compatibility
💡 Additional Notes
This translation uses Traditional Chinese characters commonly used in Taiwan (台灣正體), which differs from Simplified Chinese (zh-CN). The translation maintains technical accuracy while using terminology familiar to Taiwanese users.
🙏 Acknowledgments
Thank you for considering this contribution! Traditional Chinese support will benefit many users in Taiwan, Hong Kong, and Macau regions.