Skip to content

Conversation

@eroderust
Copy link

Abstract

From Go 1.17, the preferred syntax for build constraints is //go:build,
which replaces the old // +build form. The old style is now considered
deprecated but still supported for backward compatibility.

This change removes the obsolete // +build xxx line, keeping only the
modern //go:build xxx directive.

More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines

Design Doc / Proposal:
https://go.dev/design/draft-gobuild

@eroderust eroderust requested a review from a team as a code owner December 5, 2025 10:28
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the legacy // +build build constraint from app/appconst/pebbledb.go, aligning the codebase with modern Go practices introduced in Go 1.17. The change is a simple and effective refactoring that improves code clarity and maintainability. The change is approved.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.04%. Comparing base (0d69e1d) to head (29de4cf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   59.11%   59.04%   -0.08%     
==========================================
  Files         359      359              
  Lines       24257    24257              
==========================================
- Hits        14340    14322      -18     
- Misses       8692     8713      +21     
+ Partials     1225     1222       -3     
Files with missing lines Coverage Δ
app/appconst/pebbledb.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant