Skip to content

Commit 93f2b5f

Browse files
justinkambicmgiotakibanamachine
authored andcommitted
[Navigation] Updated Observability Serverless side nav (elastic#235984)
## Summary Continuation of the work in elastic#232456. Adds updated solution nav for o11y serverless. This PR is aimed to add in the v2 nav items that correspond to the [IA doc](https://docs.google.com/spreadsheets/d/1o6iFQWHcBNISPdhSZqE78UZzsdq6UC7x5-2_tbCO_ls/edit?pli=1&gid=582380998#gid=582380998) for both serverless complete and logs essentials pricing tiers. Additionally, the existing nav should remain as-is for v1. ## Testing this PR You'll need to test both versions of the nav. I recommend spinning up a project in serverless for complete and logs essentials. Then step through each nav item and ensure the v1 nav works in the exact manner as the production version. You don't need to do anything to change the nav to use v1, as that's enabled by default. ### Commands to set up Kibana for testing ```bash # set up Elasticsearch yarn es serverless --projectType oblt # serverless complete yarn serverless-oblt # logs essentials yarn serverless-oblt --pricing.tiers.products='[{"name":"observability","tier":"logs_essentials"}]' ``` For testing v2, update the feature flag and compare it to the [designs](https://www.figma.com/design/SDtdvdzPcaDZRRXMV02gSW/Solution-Side-Navigation--9.X-?node-id=6889-30080&t=07VzLCIBZ0vrOx8u-0), paying attention to the icons. You can configure your Kibana with the following YAML to turn on the v2 feature flag, or see both side-by-side: ```yaml feature_flags.overrides: # you can also set this to v2 if you only want to see the new nav in its normal position core.chrome.projectSideNav: 'both' ``` Use the IA doc linked above as the source of truth for the contents of all the panels. **NOTE** you may have some trouble seeing some of the cloud link items, or a few features. You can try setting up your config with the following overrides that should allow your Kibana to process most of the missing link types. ```yaml xpack.cloud.id: 'production-deployment:fake-id' xpack.cloud.base_url: 'https://cloud.elastic.co' xpack.cloud.profile_url: '/profile' xpack.cloud.billing_url: '/billing' xpack.cloud.organization_url: '/org/my-org-id' xpack.cloud.deployments_url: '/deployments' xpack.cloud.deployment_url: '/deployments/prod-123' xpack.cloud.performance_url: '/performance/prod-123' xpack.cloud.users_and_roles_url: '/security/users' xpack.dataUsage.enabled: true xpack.dataUsage.enableExperimental: [] xpack.dataUsage.autoops.enabled: true xpack.dataUsage.autoops.api.url: 'http://localhost:9000' xpack.dataUsage.autoops.api.tls.certificate: 'http://localhost:5601' xpack.dataUsage.autoops.api.tls.key: 'http://localhost:5601' ``` ~Code is WIP.~ --------- Co-authored-by: Panagiota Mitsopoulou <[email protected]> Co-authored-by: kibanamachine <[email protected]>
1 parent ca1e310 commit 93f2b5f

File tree

19 files changed

+487
-164
lines changed

19 files changed

+487
-164
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,6 +1103,7 @@ x-pack/solutions/observability/packages/kbn-evals-suite-obs-ai-assistant @elasti
11031103
x-pack/solutions/observability/packages/kbn-genai-cli @elastic/obs-knowledge-team
11041104
x-pack/solutions/observability/packages/kbn-observability-schema @elastic/obs-ux-management-team
11051105
x-pack/solutions/observability/packages/kbn-scout-oblt @elastic/appex-qa
1106+
x-pack/solutions/observability/packages/nav-icons @elastic/obs-ux-management-team
11061107
x-pack/solutions/observability/packages/observability-ai/observability-ai-common @elastic/obs-ai-assistant
11071108
x-pack/solutions/observability/packages/observability-ai/observability-ai-server @elastic/obs-ai-assistant
11081109
x-pack/solutions/observability/packages/synthetics-test-data @elastic/obs-ux-management-team

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -770,6 +770,7 @@
770770
"@kbn/observability-fixtures-plugin": "link:x-pack/platform/test/cases_api_integration/common/plugins/observability",
771771
"@kbn/observability-get-padded-alert-time-range-util": "link:x-pack/solutions/observability/packages/get-padded-alert-time-range-util",
772772
"@kbn/observability-logs-explorer-plugin": "link:x-pack/solutions/observability/plugins/observability_logs_explorer",
773+
"@kbn/observability-nav-icons": "link:x-pack/solutions/observability/packages/nav-icons",
773774
"@kbn/observability-onboarding-plugin": "link:x-pack/solutions/observability/plugins/observability_onboarding",
774775
"@kbn/observability-plugin": "link:x-pack/solutions/observability/plugins/observability",
775776
"@kbn/observability-schema": "link:x-pack/solutions/observability/packages/kbn-observability-schema",

packages/kbn-optimizer/limits.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ pageLoadAssetSize:
154154
securitySolutionServerless: 62964
155155
serverless: 10682
156156
serverlessChat: 5133
157-
serverlessObservability: 16307
157+
serverlessObservability: 22100
158158
serverlessSearch: 35000
159159
sessionView: 47938
160160
share: 58677

tsconfig.base.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,6 +1498,8 @@
14981498
"@kbn/observability-get-padded-alert-time-range-util/*": ["x-pack/solutions/observability/packages/get-padded-alert-time-range-util/*"],
14991499
"@kbn/observability-logs-explorer-plugin": ["x-pack/solutions/observability/plugins/observability_logs_explorer"],
15001500
"@kbn/observability-logs-explorer-plugin/*": ["x-pack/solutions/observability/plugins/observability_logs_explorer/*"],
1501+
"@kbn/observability-nav-icons": ["x-pack/solutions/observability/packages/nav-icons"],
1502+
"@kbn/observability-nav-icons/*": ["x-pack/solutions/observability/packages/nav-icons/*"],
15011503
"@kbn/observability-onboarding-plugin": ["x-pack/solutions/observability/plugins/observability_onboarding"],
15021504
"@kbn/observability-onboarding-plugin/*": ["x-pack/solutions/observability/plugins/observability_onboarding/*"],
15031505
"@kbn/observability-plugin": ["x-pack/solutions/observability/plugins/observability"],

x-pack/solutions/observability/plugins/observability/public/v2_icons/briefcase.tsx renamed to x-pack/solutions/observability/packages/nav-icons/icons/briefcase.tsx

File renamed without changes.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/*
2+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
3+
* or more contributor license agreements. Licensed under the Elastic License
4+
* 2.0; you may not use this file except in compliance with the Elastic License
5+
* 2.0.
6+
*/
7+
8+
export * from './briefcase';
9+
export * from './product_cloud_infra';
10+
export * from './product_ml';
11+
export * from './product_streams_wired';

x-pack/solutions/observability/plugins/observability/public/v2_icons/product_cloud_infra.tsx renamed to x-pack/solutions/observability/packages/nav-icons/icons/product_cloud_infra.tsx

File renamed without changes.

x-pack/solutions/observability/plugins/observability/public/v2_icons/product_ml.tsx renamed to x-pack/solutions/observability/packages/nav-icons/icons/product_ml.tsx

File renamed without changes.

x-pack/solutions/observability/plugins/observability/public/v2_icons/product_streams_wired.tsx renamed to x-pack/solutions/observability/packages/nav-icons/icons/product_streams_wired.tsx

File renamed without changes.
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
/*
2+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
3+
* or more contributor license agreements. Licensed under the Elastic License
4+
* 2.0; you may not use this file except in compliance with the Elastic License
5+
* 2.0.
6+
*/
7+
8+
export * from './icons';

0 commit comments

Comments
 (0)