Skip to content

Commit bf1244d

Browse files
ashokadityaNicholasPeretti
authored andcommitted
[SecuritySolution][Navigation] Update security solutions nav 2 item order (elastic#238607)
## Summary Reorders main nav items to have the same order as the current security solutions nav ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent ebe96ba commit bf1244d

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

x-pack/solutions/security/packages/navigation/src/navigation_tree/v2_navigation_tree.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,29 +52,29 @@ export const createV2NavigationTree = (core: CoreStart): NodeDefinition[] => [
5252
link: securityLink(SecurityPageName.attackDiscovery),
5353
sideNavVersion: 'v2',
5454
},
55-
defaultNavigationTree.assets(core, { sideNavVersion: 'v2' }),
56-
defaultNavigationTree.cases({ sideNavVersion: 'v2' }),
57-
defaultNavigationTree.entityAnalytics({ sideNavVersion: 'v2' }),
58-
defaultNavigationTree.explore({ sideNavVersion: 'v2' }),
59-
defaultNavigationTree.investigations({ sideNavVersion: 'v2' }),
6055
{
6156
id: SecurityPageName.cloudSecurityPostureFindings,
6257
iconV2: 'bug',
6358
link: securityLink(SecurityPageName.cloudSecurityPostureFindings),
6459
sideNavVersion: 'v2',
6560
},
66-
{
67-
id: SecurityPageName.assetInventory,
68-
iconV2: 'editorChecklist',
69-
link: securityLink(SecurityPageName.assetInventory),
70-
sideNavVersion: 'v2',
71-
},
61+
defaultNavigationTree.cases({ sideNavVersion: 'v2' }),
62+
defaultNavigationTree.entityAnalytics({ sideNavVersion: 'v2' }),
63+
defaultNavigationTree.explore({ sideNavVersion: 'v2' }),
64+
defaultNavigationTree.investigations({ sideNavVersion: 'v2' }),
7265
{
7366
id: SecurityPageName.threatIntelligence,
7467
// TODO: update icon from EUI
7568
iconV2: LazyIconBulb,
7669
link: securityLink(SecurityPageName.threatIntelligence),
7770
sideNavVersion: 'v2',
7871
},
72+
{
73+
id: SecurityPageName.assetInventory,
74+
iconV2: 'editorChecklist',
75+
link: securityLink(SecurityPageName.assetInventory),
76+
sideNavVersion: 'v2',
77+
},
78+
defaultNavigationTree.assets(core, { sideNavVersion: 'v2' }),
7979
defaultNavigationTree.ml({ sideNavVersion: 'v2' }),
8080
];

x-pack/solutions/security/plugins/security_solution_serverless/public/navigation/navigation_tree.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export const createNavigationTree = async (
6060
sideNavVersion: 'v1',
6161
},
6262
defaultNavigationTree.dashboards({ sideNavVersion: 'v1' }),
63-
6463
{
6564
breadcrumbStatus: 'hidden',
6665
children: [

0 commit comments

Comments
 (0)