Skip to content

Commit fc65234

Browse files
committed
email: rename parse_email to split_email
1 parent 1903036 commit fc65234

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/reference/lib/email.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
This contains utilities, blockers, and comparers relevant to email addresses
44

55
::: mismo.lib.email.clean_email
6-
::: mismo.lib.email.parse_email
6+
::: mismo.lib.email.split_email
77
::: mismo.lib.email.match_level
88
::: mismo.lib.email.EmailMatchLevel
99
::: mismo.lib.email.EmailsDimension

mismo/lib/email/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
from mismo.lib.email._core import EmailsDimension as EmailsDimension
77
from mismo.lib.email._core import clean_email as clean_email
88
from mismo.lib.email._core import match_level as match_level
9-
from mismo.lib.email._core import parse_email as parse_email
9+
from mismo.lib.email._core import split_email as split_email

mismo/lib/email/_core.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ def clean_email(email: ir.StringValue, *, normalize: bool = False) -> ir.StringV
2929
return email
3030

3131

32-
def parse_email(email: ir.StringValue) -> ir.StructValue:
33-
"""Parse an email into <user>@<domain> parts
32+
def split_email(email: ir.StringValue) -> ir.StructValue:
33+
"""Split an email address into <user>@<domain> parts
3434
3535
Parameters
3636
----------
@@ -87,7 +87,7 @@ def match_level(
8787
"""
8888

8989
def norm_and_parse(e):
90-
return parse_email(clean_email(e, normalize=True))
90+
return split_email(clean_email(e, normalize=True))
9191

9292
if isinstance(e1, ir.StringValue):
9393
e1 = norm_and_parse(e1)
@@ -145,7 +145,7 @@ def prepare(self, t: ir.Table) -> ir.Table:
145145
"""Add a column with the parsed and normalized email addresses."""
146146
return t.mutate(
147147
get_column(t, self.column)
148-
.map(lambda email: parse_email(clean_email(email, normalize=True)))
148+
.map(lambda email: split_email(clean_email(email, normalize=True)))
149149
.name(self.column_parsed)
150150
)
151151

mismo/lib/email/tests/test_core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def test_clean_email(input, exp):
4343
pytest.param(None, None, None, None, id="null"),
4444
],
4545
)
46-
def test_parse_email(input, expfull, expuser, expdomain):
47-
result = email.parse_email(ibis.literal(input, str)).execute()
46+
def test_split_email_address(input, expfull, expuser, expdomain):
47+
result = email.split_email(ibis.literal(input, str)).execute()
4848
assert result["full"] == expfull
4949
assert result["user"] == expuser
5050
assert result["domain"] == expdomain

0 commit comments

Comments
 (0)