Comment out unreferenced formal parameter (facebook#36853)

TatianaKapos · facebook-github-bot · commit 3c0ad81fef96 · 2023-04-14T13:07:09.000-07:00
Summary: Recent windows integration brought in a change where a unreferenced formal parameter was introduced in TurboModule.h. Windows treats with warning as an error, this change comments out the formal parameter name to get rid of the error/warning. ## Changelog: [GENERAL] [FIXED] - Comment out unreferenced formal parameter Pull Request resolved: facebook#36853 Test Plan: Passed Windows testcases Reviewed By: javache Differential Revision: D45007332 Pulled By: philIip fbshipit-source-id: 2e8128549d628a8be6bcd76c1fa473d0bc27649b
diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h b/packages/react-native/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h
@@ -120,7 +120,7 @@ class JSI_EXPORT TurboModule : public facebook::jsi::HostObject {
           static_cast<unsigned int>(meta.argCount),
           [this, meta](
               jsi::Runtime &rt,
-              const jsi::Value &thisVal,
+              [[maybe_unused]] const jsi::Value &thisVal,
               const jsi::Value *args,
               size_t count) { return meta.invoker(rt, *this, args, count); });
     }

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ class JSI_EXPORT TurboModule : public facebook::jsi::HostObject {`
`120`	`120`	`static_cast<unsigned int>(meta.argCount),`
`121`	`121`	`[this, meta](`
`122`	`122`	`jsi::Runtime &rt,`
`123`		`- const jsi::Value &thisVal,`
	`123`	`+ [[maybe_unused]] const jsi::Value &thisVal,`
`124`	`124`	`const jsi::Value *args,`
`125`	`125`	`size_t count) { return meta.invoker(rt, *this, args, count); });`
`126`	`126`	`}`