Skip to content

Commit 51f49ca

Browse files
NickGerlemanfacebook-github-bot
authored andcommitted
Fix TextInput dropping text when used as uncontrolled component with defaultValue
Summary: A layout-impacting style change will trigger a layout effect hook within `TextInput`. This hook fires a ViewManager command to set the text input based on the known JS value: https://github.com/facebook/react-native/blob/d82cd3cbce1597512bb2868fde49b5b3850892a0/Libraries/Components/TextInput/TextInput.js#L1009 The JS value is determined using `value` if set, falling back to `defaultValue`. If a component uses `TextInput` as an uncontrolled component, and does not set this value, the command wipes text input back to the default value. This does not happen on re-render of the JS side, despite setting text prop, since the underlying native property never changes/triggers a rerender. This change alters the logic to prefer `lastNativeText` instead of `defaultValue` when available, to retain the updated `TextInput` content on relayout. Reviewed By: javache Differential Revision: D37801394 fbshipit-source-id: d56c719d56bebac64553c731ce9fca8efc7feae9
1 parent f0c4c29 commit 51f49ca

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Libraries/Components/TextInput/TextInput.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -976,6 +976,8 @@ function InternalTextInput(props: Props): React.Node {
976976
const text =
977977
typeof props.value === 'string'
978978
? props.value
979+
: typeof lastNativeText === 'string'
980+
? lastNativeText
979981
: typeof props.defaultValue === 'string'
980982
? props.defaultValue
981983
: '';

0 commit comments

Comments
 (0)