Generate one Bubbling/Direct event entry when custom top name is provided

Summary:
## Context
Inside native ViewConfigs, events are declared using these bubbling/direct EventType maps:
```
{
  uiViewClassName: '...',
  bubblingEventTypes: {
    topFoo: {
      registrationName: "onFoo"
    }
  },
  directEventTypes: {},
  validAttributes: {
  },
}
```

**Pattern:** Note that the top name (i.e: topFoo) is just the registration name (i.e: onFoo) but with "on" replaced with "top".

On Android, registration names and top names don't have to follow this pattern. The top name can be **anything.** See ReactionsDockView:

https://www.internalfb.com/code/fbsource/[c430d46ed69a03a9d9f40cefa335a6d8bb92f8ec]/fbandroid/java/com/facebook/feedback/reactions/ui/overlay/react/ReactionsDockViewManager.java?lines=26-28%2C32-34%2C38

Here, ReactionDismissedEvent.EVENT_NAME is "topDismiss"

https://www.internalfb.com/code/fbsource/[c9f92314a5c46e561a831100dab82164808b05d0]/fbandroid/java/com/facebook/feedback/reactions/ui/overlay/react/ReactionDismissedEvent.java?lines=10-11%2C26

And so to provide you the flexibility to specify a custom topName, the codegen supports a customTopName in the direct/bubbling event types:

```
onDismissWithFeedbackReaction: DirectEventHandler<Event, 'topDismiss'>,
```

This generates the two bubbling event type entries in ReactionsDockView:
```
{
  uiViewClassName: '...',
  bubblingEventTypes: {
    // custom top name
    topDismiss: {
      registrationName: "onDismissWithFeedbackReaction"
    },
    // what the top name should actually be
    topDismissWithFeedbackReaction: {
      registrationName: "onDismissWithFeedbackReaction"
    }
  },
  directEventTypes: {},
  validAttributes: {
  },
}
```

**The Problem:** The entry created for "topDismissWithFeedbackReaction" is not necessary. This additional entry creates a discrepancy between ReactionsDockView's static ViewConfig and native ViewConfig. Therefore, this diff removes the second unnecessary entry.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D33418730

fbshipit-source-id: 3988ff6906ad1b2e1ef988a19c64d1e042381ab1

Author: RSNara

packages/react-native-codegen/e2e/__tests__/components/__snapshots__/GenerateViewConfigJs-test.js.snap

@@ -239,13 +239,6 @@ export default NativeComponentRegistry.get(nativeComponentName, () => ({
       },
     },
 
-    topChange: {
-      phasedRegistrationNames: {
-        captured: 'onChangeCapture',
-        bubbled: 'onChange',
-      },
-    },
-
     topEnd: {
       phasedRegistrationNames: {
         captured: 'onEndCapture',
@@ -259,13 +252,6 @@ export default NativeComponentRegistry.get(nativeComponentName, () => ({
         bubbled: 'onEventBubblingWithPaperName',
       },
     },
-
-    topEventBubblingWithPaperName: {
-      phasedRegistrationNames: {
-        captured: 'onEventBubblingWithPaperNameCapture',
-        bubbled: 'onEventBubblingWithPaperName',
-      },
-    },
   },
 
   directEventTypes: {
@@ -277,17 +263,9 @@ export default NativeComponentRegistry.get(nativeComponentName, () => ({
       registrationName: 'onEventDirectWithPaperName',
     },
 
-    topEventDirectWithPaperName: {
-      registrationName: 'onEventDirectWithPaperName',
-    },
-
     paperBubblingName: {
       registrationName: 'onOrientationChange',
     },
-
-    topOrientationChange: {
-      registrationName: 'onOrientationChange',
-    },
   },
 
   validAttributes: {

packages/react-native-codegen/src/generators/components/GenerateViewConfigJs.js

@@ -254,8 +254,9 @@ function buildViewConfig(
         bubblingEvents.push(
           generateBubblingEventInfo(event, event.paperTopLevelNameDeprecated),
         );
+      } else {
+        bubblingEvents.push(generateBubblingEventInfo(event));
       }
-      bubblingEvents.push(generateBubblingEventInfo(event));
       return bubblingEvents;
     }, []);
 
@@ -278,8 +279,9 @@ function buildViewConfig(
         directEvents.push(
           generateDirectEventInfo(event, event.paperTopLevelNameDeprecated),
         );
+      } else {
+        directEvents.push(generateDirectEventInfo(event));
       }
-      directEvents.push(generateDirectEventInfo(event));
       return directEvents;
     }, []);
 

packages/react-native-codegen/src/generators/components/__tests__/__snapshots__/GenerateViewConfigJs-test.js.snap

@@ -384,23 +384,12 @@ export default NativeComponentRegistry.get(nativeComponentName, () => ({
         bubbled: 'onChange',
       },
     },
-
-    topChange: {
-      phasedRegistrationNames: {
-        captured: 'onChangeCapture',
-        bubbled: 'onChange',
-      },
-    },
   },
 
   directEventTypes: {
     paperDirectChange: {
       registrationName: 'onDire tChange',
     },
-
-    topDire tChange: {
-      registrationName: 'onDire tChange',
-    },
   },
 
   validAttributes: {},