Skip to content

Commit da027dd

Browse files
daricheyfacebook-github-bot
authored andcommitted
Pre-suppress unused-promise lint errors in xplat/js (facebook#36590)
Summary: Pull Request resolved: facebook#36590 Pre-suppress unused-promise lint errors in xplat/js. The next diff enables the lint. See https://flow.org/en/docs/linting/rule-reference/#toc-unused-promise for more details. Changelog: [Internal] drop-conflicts bypass-lint Reviewed By: pieterv Differential Revision: D43967290 fbshipit-source-id: f36242a732dbc18bf7482adfb46ca2b77e1b1493
1 parent 0a8164d commit da027dd

File tree

8 files changed

+13
-0
lines changed

8 files changed

+13
-0
lines changed

IntegrationTests/PromiseTest.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ class PromiseTest extends React.Component<{...}> {
2222
shouldThrowAsync: boolean = false;
2323

2424
componentDidMount() {
25+
// $FlowFixMe[unused-promise]
2526
Promise.all([
2627
this.testShouldResolve(),
2728
this.testShouldReject(),

packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxSymbolication-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,19 @@ describe('LogBoxSymbolication', () => {
4141
});
4242

4343
it('symbolicates different stacks', () => {
44+
// $FlowFixMe[unused-promise]
4445
LogBoxSymbolication.symbolicate(createStack(['A', 'B', 'C']));
46+
// $FlowFixMe[unused-promise]
4547
LogBoxSymbolication.symbolicate(createStack(['D', 'E', 'F']));
4648

4749
expect(symbolicateStackTrace.mock.calls.length).toBe(2);
4850
});
4951

5052
it('batch symbolicates equivalent stacks', () => {
5153
const stack = createStack(['A', 'B', 'C']);
54+
// $FlowFixMe[unused-promise]
5255
LogBoxSymbolication.symbolicate(stack);
56+
// $FlowFixMe[unused-promise]
5357
LogBoxSymbolication.symbolicate(stack);
5458

5559
expect(symbolicateStackTrace.mock.calls.length).toBe(1);

packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1528,6 +1528,7 @@ function DisplayOptionStatusExample({
15281528
notification,
15291529
setStatusEnabled,
15301530
);
1531+
// $FlowFixMe[unused-promise]
15311532
optionChecker().then(isEnabled => {
15321533
setStatusEnabled(isEnabled);
15331534
});

packages/rn-tester/js/examples/Image/ImageExample.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ class BlobImage extends React.Component<BlobImageProps, BlobImageState> {
4848
};
4949

5050
UNSAFE_componentWillMount() {
51+
// $FlowFixMe[unused-promise]
5152
(async () => {
5253
const result = await fetch(this.props.url);
5354
const blob = await result.blob();
@@ -158,6 +159,7 @@ class NetworkImageCallbackExample extends React.Component<
158159
this._loadEventFired(
159160
`✔ Prefetch OK (+${Date.now() - mountTime}ms)`,
160161
);
162+
// $FlowFixMe[unused-promise]
161163
Image.queryCache([IMAGE_PREFETCH_URL]).then(map => {
162164
const result = map[IMAGE_PREFETCH_URL];
163165
if (result) {

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,7 @@ const RefreshControlExample = () => {
741741
const [refreshing, setRefreshing] = useState(false);
742742
const onRefresh = useCallback(() => {
743743
setRefreshing(true);
744+
// $FlowFixMe[unused-promise]
744745
wait(2000).then(() => setRefreshing(false));
745746
}, []);
746747

packages/rn-tester/js/examples/Share/ShareExample.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const React = require('react');
1515
const {StyleSheet, View, Text, Button, Share} = require('react-native');
1616

1717
const shareMessage = () => {
18+
// $FlowFixMe[unused-promise]
1819
Share.share({
1920
message:
2021
('Our top priority for React Native is to match the expectations people have for each platform. This is why React Native renders to platform primitives. We value native look-and-feel over cross-platform consistency.' +
@@ -23,6 +24,7 @@ const shareMessage = () => {
2324
};
2425

2526
const shareText = () => {
27+
// $FlowFixMe[unused-promise]
2628
Share.share(
2729
{
2830
title: 'Massive Scale',

packages/rn-tester/js/examples/XHR/XHRExampleBinaryUpload.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ class XHRExampleBinaryUpload extends React.Component<{...}, $FlowFixMeState> {
7171
}
7272
const url = xhr.responseText.slice(index).split('\n')[0];
7373
console.log('Upload successful: ' + url);
74+
// $FlowFixMe[unused-promise]
7475
Linking.openURL(url);
7576
}
7677

packages/rn-tester/js/examples/XHR/XHRExampleFetch.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class XHRExampleFetch extends React.Component<any, any> {
2828
}
2929

3030
submit(uri: string) {
31+
// $FlowFixMe[unused-promise]
3132
fetch(uri)
3233
.then(response => {
3334
this.responseURL = response.url;

0 commit comments

Comments
 (0)