Skip to content

Commit 6110984

Browse files
committed
simplify script
Signed-off-by: nicklucche <[email protected]>
1 parent 8a28025 commit 6110984

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/v1/kv_connector/nixl_integration/run_accuracy_test.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ run_tests_for_model() {
5555

5656
# Get model-specific arguments
5757
local model_args=$(get_model_args "$model_name")
58-
set_cli_args "$@"
5958

6059
# Arrays to store all hosts and ports
6160
PREFILL_HOSTS=()
@@ -77,7 +76,7 @@ run_tests_for_model() {
7776
echo "Starting prefill instance $i on GPU $GPU_ID, port $PORT"
7877

7978
# Build the command with or without model-specific args
80-
BASE_CMD="VLLM_WORKER_MULTIPROC_METHOD=spawn VLLM_ENABLE_V1_MULTIPROCESSING=0 CUDA_VISIBLE_DEVICES=$GPU_ID VLLM_NIXL_SIDE_CHANNEL_PORT=$SIDE_CHANNEL_PORT vllm serve $model_name \
79+
BASE_CMD="CUDA_VISIBLE_DEVICES=$GPU_ID VLLM_NIXL_SIDE_CHANNEL_PORT=$SIDE_CHANNEL_PORT vllm serve $model_name \
8180
--port $PORT \
8281
--enforce-eager \
8382
--disable-log-requests \
@@ -91,7 +90,7 @@ run_tests_for_model() {
9190
FULL_CMD="$BASE_CMD"
9291
fi
9392

94-
eval "$FULL_CMD 2>&1 > out_prefiller &"
93+
eval "$FULL_CMD 2>&1 &"
9594

9695
# Store host and port for proxy configuration
9796
PREFILL_HOSTS+=("localhost")
@@ -111,7 +110,7 @@ run_tests_for_model() {
111110
echo "Starting decode instance $i on GPU $GPU_ID, port $PORT"
112111

113112
# Build the command with or without model-specific args
114-
BASE_CMD="VLLM_WORKER_MULTIPROC_METHOD=spawn VLLM_ENABLE_V1_MULTIPROCESSING=0 CUDA_VISIBLE_DEVICES=$GPU_ID VLLM_NIXL_SIDE_CHANNEL_PORT=$SIDE_CHANNEL_PORT vllm serve $model_name \
113+
BASE_CMD="CUDA_VISIBLE_DEVICES=$GPU_ID VLLM_NIXL_SIDE_CHANNEL_PORT=$SIDE_CHANNEL_PORT vllm serve $model_name \
115114
--port $PORT \
116115
--enforce-eager \
117116
--disable-log-requests \
@@ -125,7 +124,7 @@ run_tests_for_model() {
125124
FULL_CMD="$BASE_CMD"
126125
fi
127126

128-
eval "$FULL_CMD 2>&1 > out_decoder &"
127+
eval "$FULL_CMD &"
129128

130129
# Store host and port for proxy configuration
131130
DECODE_HOSTS+=("localhost")
@@ -172,7 +171,7 @@ run_tests_for_model() {
172171

173172
# Run tests for each model
174173
for model in "${MODELS[@]}"; do
175-
run_tests_for_model "$model" "$@"
174+
run_tests_for_model "$model"
176175
done
177176

178177
echo "All tests completed!"

0 commit comments

Comments
 (0)