Skip to content

Commit 4d6cb11

Browse files
committed
Added option for showing or hiding view initially
1 parent 68bd1d5 commit 4d6cb11

File tree

10 files changed

+22
-108
lines changed

10 files changed

+22
-108
lines changed

.idea/assetWizardSettings.xml

Lines changed: 0 additions & 47 deletions
This file was deleted.

.idea/codeStyles/codeStyleConfig.xml

Lines changed: 0 additions & 5 deletions
This file was deleted.

.idea/dictionaries/nickmowen.xml

Lines changed: 0 additions & 7 deletions
This file was deleted.

.idea/misc.xml

Lines changed: 5 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/vcs.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
// Top-level build file where you can add configuration options common to all sub-projects/modules.
22

33
buildscript {
4-
ext.kotlin_version = '1.3.10'
4+
ext.kotlin_version = '1.3.20'
55
repositories {
66
google()
77
jcenter()
88
}
99
dependencies {
10-
classpath 'com.android.tools.build:gradle:3.3.0-beta04'
10+
classpath 'com.android.tools.build:gradle:3.3.0'
1111
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
1212

1313
//For Library

linkpreview/build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ android {
99
defaultConfig {
1010
minSdkVersion 19
1111
targetSdkVersion 28
12-
versionCode 16
13-
versionName "2.1"
12+
versionCode 17
13+
versionName "2.2"
1414
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1515
}
1616
buildTypes {
@@ -43,8 +43,8 @@ dependencies {
4343

4444
//Testing libraries
4545
testImplementation 'org.jetbrains.kotlin:kotlin-test-junit:1.2.31'
46-
androidTestImplementation 'androidx.test:runner:1.1.0'
47-
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
46+
androidTestImplementation 'androidx.test:runner:1.1.1'
47+
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
4848
}
4949

5050
ext {
@@ -54,7 +54,7 @@ ext {
5454

5555
publishedGroupId = 'com.nick.mowen.linkpreview'
5656
artifact = 'linkpreview'
57-
libraryVersion = '2.1'
57+
libraryVersion = '2.2'
5858
libraryDescription = 'A convenient view that shows a clickable preview of a link'
5959
siteUrl = 'https://github.com/NickM-27/LinkPreview'
6060
gitUrl = 'https://github.com/NickM-27/LinkPreview.git'

linkpreview/src/main/java/com/nick/mowen/linkpreview/binding/BindingAdapter.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,5 @@ object BindingAdapter {
77

88
@BindingAdapter("parsedLink")
99
@JvmStatic
10-
fun setParsedLink(view: LinkPreview, link: String) {
11-
view.parseTextForLink(link)
12-
}
10+
fun setParsedLink(view: LinkPreview, link: String) = view.parseTextForLink(link)
1311
}

linkpreview/src/main/java/com/nick/mowen/linkpreview/view/LinkPreview.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import android.widget.ImageView
1010
import android.widget.TextView
1111
import androidx.browser.customtabs.CustomTabsIntent
1212
import androidx.core.net.toUri
13+
import androidx.core.view.isGone
1314
import com.bumptech.glide.Glide
1415
import com.nick.mowen.linkpreview.ImageType
1516
import com.nick.mowen.linkpreview.R
@@ -35,6 +36,8 @@ open class LinkPreview : FrameLayout, View.OnClickListener {
3536
var clickListener: LinkClickListener? = null
3637
/** Optional click listener to override click behavior */
3738
var articleColor: Int = Color.CYAN
39+
/** Set whether or not to default to hidden while loading preview */
40+
var hideWhileLoading = false
3841

3942
/** Color of the Chrome CustomTab that is launched on view click */
4043

@@ -68,7 +71,9 @@ open class LinkPreview : FrameLayout, View.OnClickListener {
6871
if (isInEditMode)
6972
return
7073

71-
visibility = View.GONE
74+
if (hideWhileLoading)
75+
isGone = true
76+
7277
image = findViewById(R.id.preview_image)
7378
text = findViewById(R.id.preview_text)
7479
setOnClickListener(this)

sample/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@ dependencies {
4444
//Testing Libraries
4545
testImplementation 'org.jetbrains.kotlin:kotlin-test-junit:1.2.31'
4646

47-
androidTestImplementation 'androidx.test:runner:1.1.0-beta02'
48-
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0-beta02'
47+
androidTestImplementation 'androidx.test:runner:1.1.1'
48+
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
4949
}

0 commit comments

Comments
 (0)