More maybe_unused

NicksWorld · NicksWorld · commit cf28bd362121 · 2025-11-14T09:41:38.000-05:00
diff --git a/library/Crashlog.cpp b/library/Crashlog.cpp
@@ -36,7 +36,7 @@ void signal_crashlog_complete() {
     if (crashlog_complete == -1)
         return;
     uint64_t v = 1;
-    write(crashlog_complete, &v, sizeof(v));
+    [[maybe_unused]] auto _ = write(crashlog_complete, &v, sizeof(v));
 }
 
 std::thread crashlog_thread;
@@ -55,8 +55,8 @@ extern "C" void dfhack_crashlog_handle_signal(int sig) {
     flag_set(crashlog_ready);
     // Wait for completion via eventfd read, if fd isn't valid, bail
     if (crashlog_complete != -1) {
-        [[maybe_unused]] uint64_t _;
-        read(crashlog_complete, &_, sizeof(_));
+        [[maybe_unused]] uint64_t v;
+        [[maybe_unused]] auto _ = read(crashlog_complete, &v, sizeof(v));
     }
     std::quick_exit(1);
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ void signal_crashlog_complete() {`
`36`	`36`	`if (crashlog_complete == -1)`
`37`	`37`	`return;`
`38`	`38`	`uint64_t v = 1;`
`39`		`- write(crashlog_complete, &v, sizeof(v));`
	`39`	`+ [[maybe_unused]] auto _ = write(crashlog_complete, &v, sizeof(v));`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`std::thread crashlog_thread;`
`@@ -55,8 +55,8 @@ extern "C" void dfhack_crashlog_handle_signal(int sig) {`
`55`	`55`	`flag_set(crashlog_ready);`
`56`	`56`	`// Wait for completion via eventfd read, if fd isn't valid, bail`
`57`	`57`	`if (crashlog_complete != -1) {`
`58`		`- [[maybe_unused]] uint64_t _;`
`59`		`- read(crashlog_complete, &_, sizeof(_));`
	`58`	`+ [[maybe_unused]] uint64_t v;`
	`59`	`+ [[maybe_unused]] auto _ = read(crashlog_complete, &v, sizeof(v));`
`60`	`60`	`}`
`61`	`61`	`std::quick_exit(1);`
`62`	`62`	`}`