Skip to content

Commit 3c8a30a

Browse files
nlogozzonlogozzo
committed
fix: GitHub Rate Limiting
1 parent 94a6ff9 commit 3c8a30a

File tree

8 files changed

+46
-18
lines changed

8 files changed

+46
-18
lines changed

‎.github/workflows/macos.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ permissions:
1212
env:
1313
TEST_PROJECT_NAME: Nickvision.Desktop.Tests
1414
KEYRING_PASSWORD: "abc"
15+
CI: true
1516
jobs:
1617
build:
1718
name: "Build on macOS"

‎.github/workflows/windows.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ permissions:
1111
contents: read
1212
env:
1313
TEST_PROJECT_NAME: Nickvision.Desktop.Tests
14+
CI: true
1415
jobs:
1516
build:
1617
name: "Build on Windows"

‎Nickvision.Desktop.Tests/DatabaseKeyringServiceTests.cs‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using System.IO;
77
using System.Linq;
88
using System.Threading.Tasks;
9+
using Environment = System.Environment;
910

1011
namespace Nickvision.Desktop.Tests;
1112

@@ -17,7 +18,7 @@ public sealed class DatabaseKeyringServiceTests
1718
[TestMethod]
1819
public void Case001_Init()
1920
{
20-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
21+
if (Environment.GetEnvironmentVariable("CI") == "true")
2122
{
2223
Assert.Inconclusive("Dialogs are not supported in CI environments");
2324
}
@@ -31,7 +32,7 @@ public void Case001_Init()
3132
[TestMethod]
3233
public void Case002_Check()
3334
{
34-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
35+
if (Environment.GetEnvironmentVariable("CI") == "true")
3536
{
3637
Assert.Inconclusive("Dialogs are not supported in CI environments");
3738
}
@@ -42,7 +43,7 @@ public void Case002_Check()
4243
[TestMethod]
4344
public async Task Case003_Add()
4445
{
45-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
46+
if (Environment.GetEnvironmentVariable("CI") == "true")
4647
{
4748
Assert.Inconclusive("Dialogs are not supported in CI environments");
4849
}
@@ -55,7 +56,7 @@ public async Task Case003_Add()
5556
[TestMethod]
5657
public async Task Case004_Update()
5758
{
58-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
59+
if (Environment.GetEnvironmentVariable("CI") == "true")
5960
{
6061
Assert.Inconclusive("Dialogs are not supported in CI environments");
6162
}
@@ -73,7 +74,7 @@ public async Task Case004_Update()
7374
[TestMethod]
7475
public async Task Case005_Remove()
7576
{
76-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
77+
if (Environment.GetEnvironmentVariable("CI") == "true")
7778
{
7879
Assert.Inconclusive("Dialogs are not supported in CI environments");
7980
}
@@ -88,7 +89,7 @@ public async Task Case005_Remove()
8889
[TestMethod]
8990
public async Task Case006_Cleanup()
9091
{
91-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
92+
if (Environment.GetEnvironmentVariable("CI") == "true")
9293
{
9394
Assert.Inconclusive("Dialogs are not supported in CI environments");
9495
}

‎Nickvision.Desktop.Tests/GitHubUpdaterServiceTests.cs‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ public class GitHubUpdaterServiceTests
1616
[ClassInitialize]
1717
public static void ClassInitialize(TestContext context)
1818
{
19+
if (Environment.GetEnvironmentVariable("CI") == "true")
20+
{
21+
return;
22+
}
1923
_client = new HttpClient();
2024
var path = Path.Combine(UserDirectories.Cache, "NickvisionApps_Parabolic_Setup.exe");
2125
if (File.Exists(path))
@@ -33,6 +37,10 @@ public static void ClassCleanup()
3337
[TestMethod]
3438
public void Case001_Initialize()
3539
{
40+
if (Environment.GetEnvironmentVariable("CI") == "true")
41+
{
42+
Assert.Inconclusive("Dialogs are not supported in CI environments");
43+
}
3644
Assert.IsNotNull(_client);
3745
_updaterService = new GitHubUpdaterService(new AppInfo("org.nickvision.tubeconverter", "Nickvision Parabolic", "Parabolic")
3846
{
@@ -45,6 +53,10 @@ public void Case001_Initialize()
4553
[TestMethod]
4654
public async Task Case002_CheckForStableUpdates()
4755
{
56+
if (Environment.GetEnvironmentVariable("CI") == "true")
57+
{
58+
Assert.Inconclusive("Dialogs are not supported in CI environments");
59+
}
4860
Assert.IsNotNull(_updaterService);
4961
var version = await _updaterService.GetLatestStableVersionAsync();
5062
Assert.IsNotNull(version);
@@ -54,6 +66,10 @@ public async Task Case002_CheckForStableUpdates()
5466
[TestMethod]
5567
public async Task Case003_CheckForPreviewUpdates()
5668
{
69+
if (Environment.GetEnvironmentVariable("CI") == "true")
70+
{
71+
Assert.Inconclusive("Dialogs are not supported in CI environments");
72+
}
5773
Assert.IsNotNull(_updaterService);
5874
var version = await _updaterService.GetLatestPreviewVersionAsync();
5975
Assert.IsNotNull(version);
@@ -63,6 +79,10 @@ public async Task Case003_CheckForPreviewUpdates()
6379
[TestMethod]
6480
public async Task Case004_CompareVersions()
6581
{
82+
if (Environment.GetEnvironmentVariable("CI") == "true")
83+
{
84+
Assert.Inconclusive("Dialogs are not supported in CI environments");
85+
}
6686
Assert.IsNotNull(_updaterService);
6787
var preview = await _updaterService.GetLatestPreviewVersionAsync();
6888
var stable = await _updaterService.GetLatestStableVersionAsync();
@@ -75,6 +95,10 @@ public async Task Case004_CompareVersions()
7595
[TestMethod]
7696
public async Task Check005_WindowsUpdate()
7797
{
98+
if (Environment.GetEnvironmentVariable("CI") == "true")
99+
{
100+
Assert.Inconclusive("Dialogs are not supported in CI environments");
101+
}
78102
Assert.IsNotNull(_updaterService);
79103
var version = await _updaterService.GetLatestStableVersionAsync();
80104
Assert.IsNotNull(version);

‎Nickvision.Desktop.Tests/JsonFileServiceTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public static void ClassInitialize(TestContext context)
3636
File.Delete(configAsyncPath);
3737
}
3838
}
39-
39+
4040
[TestMethod]
4141
public void Case001_Initialize()
4242
{

‎Nickvision.Desktop.Tests/SystemSecretServiceTests.cs‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using Nickvision.Desktop.System;
22
using System.Runtime.Versioning;
33
using System.Threading.Tasks;
4+
using Environment = System.Environment;
45

56
namespace Nickvision.Desktop.Tests;
67

@@ -15,7 +16,7 @@ public sealed class SystemSecretServiceTests
1516
[TestMethod]
1617
public void Case001_Initialize()
1718
{
18-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
19+
if (Environment.GetEnvironmentVariable("CI") == "true")
1920
{
2021
Assert.Inconclusive("Dialogs are not supported in CI environments");
2122
}
@@ -26,7 +27,7 @@ public void Case001_Initialize()
2627
[TestMethod]
2728
public async Task Case002_Add()
2829
{
29-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
30+
if (Environment.GetEnvironmentVariable("CI") == "true")
3031
{
3132
Assert.Inconclusive("Dialogs are not supported in CI environments");
3233
}
@@ -39,7 +40,7 @@ public async Task Case002_Add()
3940
[TestMethod]
4041
public async Task Case003_Create()
4142
{
42-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
43+
if (Environment.GetEnvironmentVariable("CI") == "true")
4344
{
4445
Assert.Inconclusive("Dialogs are not supported in CI environments");
4546
}
@@ -52,7 +53,7 @@ public async Task Case003_Create()
5253
[TestMethod]
5354
public void Case004_Create()
5455
{
55-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
56+
if (Environment.GetEnvironmentVariable("CI") == "true")
5657
{
5758
Assert.Inconclusive("Dialogs are not supported in CI environments");
5859
}
@@ -65,7 +66,7 @@ public void Case004_Create()
6566
[TestMethod]
6667
public async Task Case005_Get()
6768
{
68-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
69+
if (Environment.GetEnvironmentVariable("CI") == "true")
6970
{
7071
Assert.Inconclusive("Dialogs are not supported in CI environments");
7172
}
@@ -80,7 +81,7 @@ public async Task Case005_Get()
8081
[TestMethod]
8182
public async Task Case006_Get()
8283
{
83-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
84+
if (Environment.GetEnvironmentVariable("CI") == "true")
8485
{
8586
Assert.Inconclusive("Dialogs are not supported in CI environments");
8687
}
@@ -97,7 +98,7 @@ public async Task Case006_Get()
9798
[TestMethod]
9899
public async Task Case007_Update()
99100
{
100-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
101+
if (Environment.GetEnvironmentVariable("CI") == "true")
101102
{
102103
Assert.Inconclusive("Dialogs are not supported in CI environments");
103104
}
@@ -117,7 +118,7 @@ public async Task Case007_Update()
117118
[TestMethod]
118119
public async Task Case008_Update()
119120
{
120-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
121+
if (Environment.GetEnvironmentVariable("CI") == "true")
121122
{
122123
Assert.Inconclusive("Dialogs are not supported in CI environments");
123124
}
@@ -137,7 +138,7 @@ public async Task Case008_Update()
137138
[TestMethod]
138139
public async Task Case009_Delete()
139140
{
140-
if (global::System.Environment.GetEnvironmentVariable("CI") == "true")
141+
if (Environment.GetEnvironmentVariable("CI") == "true")
141142
{
142143
Assert.Inconclusive("Dialogs are not supported in CI environments");
143144
}

‎Nickvision.Desktop/Application/GitHubUpdaterService.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public async Task<bool> DownloadReleaseAssetAsync(Version version,
139139
}
140140
return null;
141141
}
142-
catch(Exception)
142+
catch (Exception)
143143
{
144144
return null;
145145
}

‎Nickvision.Desktop/Keyring/PasswordGenerator.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static PasswordGenerator()
3232
];
3333
SpecialChars =
3434
[
35-
'!', '#', '$', '%', '&', '(', ')', '*', '+', ',', '-', '.', '/', ':', ';', '<', '=', '>', '?', '@', '[',
35+
'!', '#', '$', '%', '&', '(', ')', '*', '+', ',', '-', '.', '/', ':', ';', '<', '=', '>', '?', '@', '[',
3636
'\\', ']', '^', '_', '`', '{', '|', '}', '~'
3737
];
3838
}

0 commit comments

Comments
 (0)