Update docs

Author: nlogozzo

docs/notifications.md

@@ -88,7 +88,6 @@ Path: `Nickvision::Notifications::NotifyIcon`
   ``` 
     - Constructs a NotifyIcon.
     - Accepts: The `HWND` handle for the main application window, hwnd, the context menu model for the icon, contextMenu, and whether or not to hide the icon by default, hidden.
-    - Throws: std::logic_error if Aura::init() was not called yet.
     - Throws: std::runtime_error if unable to create the NotifyIcon.
 - ```cpp
   ~NotifyIcon()
@@ -224,15 +223,13 @@ Path: `Nickvision::Notifications::ShellNotification`
     - Accepts: The `ShellNotificationSentEventArgs` containing the information to show, e, and the `HWND` handle for the main application window, hwnd. The hwnd parameter is only used once on the initial creation of the static `NotifyIcon` and then is ignored on future calls.
     - Note: This function is only available on the Windows platform. It uses `Nickvision::Notifications::NotifyIcon`.
     - Note: This function supports the action "open" with action param being a path of a file or folder to open.
-    - Throws: std::logic_error if Aura::init() was not called yet 
 - ```cpp
   void send(const ShellNotificationSentEventArgs& e, const std::string& openText)
   ``` 
     - Accepts: The `ShellNotificationSentEventArgs` containing the information to show, e, and the localized text of "Open", openText.
     - Note: This function is only available on the Linux platform.
     - Note: This function supports the action "open" with action param being a path of a file or folder to open. The app must define an "app.open" action to handle this event.
-    - Throws: std::logic_error if Aura::init() was not called yet 
-
+    
 ## ShellNotificationSentEventArgs
 Description: Event args for when a shell notification is sent.
 

include/notifications/notifyicon.h

@@ -27,7 +27,6 @@ namespace Nickvision::Notifications
 		 * @param hwnd The HWND handle of the main application window
 		 * @param menu The model for the context menu of the NotifyIcon
 		 * @param hidden Whether or not the NotifyIcon should be hidden by default
-		 * @throw std::logic_error Thrown if Aura::init() was not called yet 
 		 * @throw std::runtime_error Thrown if unable to create the NotifyIcon
 		 */
 		NotifyIcon(HWND hwnd, const NotifyIconMenu& contextMenu = { }, bool hidden = false);

include/notifications/shellnotification.h

@@ -16,7 +16,6 @@ namespace Nickvision::Notifications::ShellNotification
 	 * @brief Supports the action "open" with action param being a path of a file or folder to open.
 	 * @param e ShellNotificationSentEventArgs
 	 * @param hwnd The HWND handle of the main application window. This parameter is only used once on the initial creation of the static NotifyIcon and then is ignored on future calls
-	 * @throw std::logic_error Thrown if Aura::init() was not yet called
 	 */
 	void send(const ShellNotificationSentEventArgs& e, HWND hwnd);
 #elif defined(__linux__)
@@ -26,7 +25,6 @@ namespace Nickvision::Notifications::ShellNotification
 	 * @brief Supports the action "open" with action param being a path of a file or folder to open. The app must define an "app.open" action to handle this event.
 	 * @param e ShellNotificationSentEventArgs
 	 * @param openText Localized text of "Open"
-	 * @throw std::logic_error Thrown if Aura::init() was not yet called
 	 */
 	void send(const ShellNotificationSentEventArgs& e, const std::string& openText);
 #endif

src/keyring/passwordgenerator.cpp

@@ -45,7 +45,7 @@ namespace Nickvision::Keyring
 	std::string PasswordGenerator::next(size_t length)
 	{
 		std::string pass;
-        for(int i = 0; i < length; i++)
+        for(size_t i = 0; i < length; i++)
         {
             pass += m_chars[rand() % m_chars.size()];
         }