V2025.6.4

Author: nlogozzo

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 2025.6.4
+### Breaking Changes
+None
+### New APIs
+None
+### Fixes
+#### System
+- Fixed an issue where `Process::pause()` and `Process::resume()` did not work correctly on Windows
+
 ## 2025.6.3
 ### Breaking Changes
 None

CMakeLists.txt

@@ -20,7 +20,7 @@ endif()
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
 
 #libnick Definition
-project ("libnick" LANGUAGES C CXX VERSION 2025.6.3 DESCRIPTION "A cross-platform base for native Nickvision applications.")
+project ("libnick" LANGUAGES C CXX VERSION 2025.6.4 DESCRIPTION "A cross-platform base for native Nickvision applications.")
 include(CMakePackageConfigHelpers)
 include(GNUInstallDirs)
 include(CTest)

README.md

@@ -91,4 +91,4 @@ A C++20 compiler is also required to build libnick.
         ```
         find_package(libnick CONFIG REQUIRED)
         target_link_libraries(main PRIVATE libnick::libnick)
-        ```
+        ```

manual/README.md

@@ -6,44 +6,36 @@
 
 libnick provides Nickvision apps with a common set of cross-platform APIs for managing system and desktop app functionality such as network management, taskbar icons, translations, app updates, and more.
 
-## 2025.6.3
+## 2025.6.4
 ### Breaking Changes
 None
 ### New APIs
 None
 ### Fixes
-- Fixed an issue with the cmake configuration file
+#### System
+- Fixed an issue where `Process::pause()` and `Process::resume()` did not work correctly on Windows
 
 ## Dependencies
-The following are a list of dependencies used by libnick. 
+The following are a list of dependencies used by libnick.
+
+The recommendation and below commands will use vcpkg to pull these dependencies. However, vcpkg is not a requirement as long as the system provides these dependencies correctly.
 
 ### All Platforms
 - boost-json
 - gtest
 - libcurl
 - libintl
 - maddy
+- sqlcipher (Must be provided by the system on Linux and macOS as sqlcipher is not available via vcpkg for these systems)
 
-### Windows
-The above dependencies must be installed, *plus* the following for Windows systems:
-- sqlcipher
-
-### Linux
-The above dependencies must be installed, *plus* the following for Linux systems:
+### Linux and macOS
+The above dependencies must be installed, *plus* the following for Linux and macOS systems:
 - glib
 - libsecret
-- openssl
-    - Used for sqlcipher, as libnick manually builds sqlcipher on Linux as the vcpkg port is broken.
-
-### macOS
-The above dependencies must be installed, *plus* the following for macOS systems:
-- glib
-- libsecret (Only required if `-DUSE_LIBSECRET="ON"`)
-- openssl
-    - Used for sqlcipher, as libnick manually builds sqlcipher on macOS as the vcpkg port is broken.
+  - For macOS: Only required if `-DUSE_LIBSECRET="ON"`
 
 ## Consuming libnick via vcpkg
-libnick is available through `vcpkg`. 
+libnick is available through `vcpkg`.
 
 Simply install and configure vcpkg for your system, and run:
 ```
@@ -56,9 +48,9 @@ target_link_libraries(main PRIVATE libnick::libnick)
 ```
 
 ## Building and Installing Manually
-libnick uses `vcpkg` to manage its dependencies and `cmake` as its build system.
+libnick uses `cmake` as its build system and `vcpkg` to *optionally* manage its dependencies.
 
-Ensure both `vcpkg` and `cmake` are installed on your system before building and installing libnick.
+Ensure `cmake` and `vcpkg` are installed on your system before building and installing libnick.
 
 A C++20 compiler is also required to build libnick.
 
@@ -69,42 +61,39 @@ A C++20 compiler is also required to build libnick.
 1. Run `vcpkg install boost-json curl gettext-libintl gtest maddy sqlcipher`
 #### Linux
 1. Set the `VCPKG_DEFAULT_TRIPLET` environment variable to `x64-linux`
-1. Run `vcpkg install boost-json curl gettext-libintl glib gtest libsecret maddy openssl`
-#### macOS (Intel)
-1. Set the `VCPKG_DEFAULT_TRIPLET` environment variable to `x64-osx`
-1. Run `vcpkg install boost-json curl gettext-libintl glib gtest libsecret maddy openssl`
+1. Run `vcpkg install boost-json curl gettext-libintl glib gtest libsecret maddy`
 #### macOS (Apple Silicon)
 1. Set the `VCPKG_DEFAULT_TRIPLET` environment variable to `arm64-osx`
-1. Run `vcpkg install boost-json curl gettext-libintl glib gtest libsecret maddy openssl`
+1. Run `vcpkg install boost-json curl gettext-libintl glib gtest libsecret maddy`
 
 ### Building
 1. First, clone/download the repo.
 1. Open a terminal and navigate to the repo's root directory.
-1. Create a new `build` directory and `cd` into it. 
+1. Create a new `build` directory and `cd` into it.
 #### Windows
 1. From the `build` folder, run `cmake .. -G "Visual Studio 17 2022"`.
-    - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
-    - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
+  - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
+  - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
 1. From the `build` folder, run `cmake --build . --config Release`.
 1. After these commands complete, libnick will be successfully built and its binaries can be found in the `Release` folder of the `build` folder.
 #### Linux
 1. From the `build` folder, run `cmake .. -DCMAKE_BUILD_TYPE=Release`.
-    - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
-    - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
+  - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
+  - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
 1. From the `build` folder, run `cmake --build .`.
 1. After these commands complete, libnick will be successfully built and its binaries can be found in the `build` folder.
 #### macOS
 1. From the `build` folder, run `cmake .. -DCMAKE_BUILD_TYPE=Release`.
-    - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
-    - To use `libsecret` instead of macOS's built in security library, add `-DUSE_LIBSECRET="ON"` to the end of the command.
-    - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
+  - To skip building libnick's test suite, add `-DBUILD_TESTING="OFF"` to the end of the command.
+  - To use `libsecret` instead of macOS's built in security library, add `-DUSE_LIBSECRET="ON"` to the end of the command.
+  - If you plan to install libnick, add `-DCMAKE_INSTALL_PREFIX=PATH_TO_INSTALL_DIR` to the end of the command, replacing `PATH_TO_INSTALL_DIR` with the path of where you'd like libnick to install to.
 1. From the `build` folder, run `cmake --build .`.
 1. After these commands complete, libnick will be successfully built and its binaries can be found in the `build` folder.
 
 ### Installing
 1. To install libnick to the system, from the `build` folder, run `cmake --install .`.
-    - This command will export and install libnick cmake targets allowing you to simply use libnick in other cmake projects with the following:
-        ```
-        find_package(libnick CONFIG REQUIRED)
-        target_link_libraries(main PRIVATE libnick::libnick)
-        ```
+  - This command will export and install libnick cmake targets allowing you to simply use libnick in other cmake projects with the following:
+      ```
+      find_package(libnick CONFIG REQUIRED)
+      target_link_libraries(main PRIVATE libnick::libnick)
+      ```

src/system/process.cpp

@@ -442,15 +442,28 @@ namespace Nickvision::System
 #ifndef _WIN32
         ::kill(-m_pid, SIGCONT);
         if(::kill(m_pid, SIGCONT) < 0)
-#else
-        if(!DebugActiveProcessStop(m_pi.dwProcessId))
-#endif
-
         {
             return false;
         }
-#ifdef _WIN32
-        DebugSetProcessKillOnExit(false);
+#else
+        HANDLE snapshot{ CreateToolhelp32Snapshot(TH32CS_SNAPTHREAD, 0) };
+        THREADENTRY32 entry{ sizeof(THREADENTRY32) };
+        if(Thread32First(snapshot, &entry))
+        {
+            do
+            {
+                if(entry.th32OwnerProcessID == m_pi.dwProcessId)
+                {
+                    HANDLE thread{ OpenThread(THREAD_SUSPEND_RESUME, false, entry.th32ThreadID) };
+                    if(thread)
+                    {
+                        ResumeThread(thread);
+                        CloseHandle(thread);
+                    }
+                }
+            } while(Thread32Next(snapshot, &entry));
+        }
+        CloseHandle(snapshot);
 #endif
         m_state = ProcessState::Running;
         return true;
@@ -466,12 +479,29 @@ namespace Nickvision::System
 #ifndef _WIN32
         ::kill(-m_pid, SIGSTOP);
         if(::kill(m_pid, SIGSTOP) < 0)
-#else
-        if(!DebugActiveProcess(m_pi.dwProcessId))
-#endif
         {
             return false;
         }
+#else
+        HANDLE snapshot{ CreateToolhelp32Snapshot(TH32CS_SNAPTHREAD, 0) };
+        THREADENTRY32 entry{ sizeof(THREADENTRY32) };
+        if(Thread32First(snapshot, &entry))
+        {
+            do
+            {
+                if(entry.th32OwnerProcessID == m_pi.dwProcessId)
+                {
+                    HANDLE thread{ OpenThread(THREAD_SUSPEND_RESUME, false, entry.th32ThreadID) };
+                    if(thread)
+                    {
+                        SuspendThread(thread);
+                        CloseHandle(thread);
+                    }
+                }
+            } while(Thread32Next(snapshot, &entry));
+        }
+        CloseHandle(snapshot);
+#endif
         m_state = ProcessState::Paused;
         return true;
     }
@@ -513,12 +543,15 @@ namespace Nickvision::System
 #ifndef _WIN32
         int status{ 0 };
 #endif
-        bool ended{ false };
-        while(!ended)
+        DWORD exitCode{ 0 };
+        do
         {
 #ifdef _WIN32
             //Determine if ended
-            ended = WaitForSingleObject(m_pi.hProcess, 0) == WAIT_OBJECT_0;
+            if(!GetExitCodeProcess(m_pi.hProcess, &exitCode))
+            {
+                exitCode = STILL_ACTIVE;
+            }
             //Read console output
             while(true)
             {
@@ -556,18 +589,10 @@ namespace Nickvision::System
             }
 #endif
             std::this_thread::sleep_for(std::chrono::milliseconds(PROCESS_WAIT_TIMEOUT));
-        }
+        } while(exitCode == STILL_ACTIVE);
         std::unique_lock<std::mutex> lock{ m_mutex };
 #ifdef _WIN32
-        DWORD exitCode{ 0 };
-        if(GetExitCodeProcess(m_pi.hProcess, &exitCode))
-        {
-            m_exitCode = static_cast<int>(exitCode);
-        }
-        else
-        {
-            m_exitCode = -1;
-        }
+        m_exitCode = static_cast<int>(exitCode);
 #else
         m_exitCode = WIFEXITED(status) ? WEXITSTATUS(status) : -1;
 #endif

tests/processtests.cpp

@@ -16,7 +16,7 @@ std::unique_ptr<Process> ProcessTest::m_proc{ nullptr };
 TEST_F(ProcessTest, Create)
 {
 #ifdef _WIN32
-    ASSERT_NO_THROW(m_proc = std::make_unique<Process>(Environment::findDependency("cmd.exe"), std::vector<std::string>{ "/c", "start", "/min", "timeout.exe", "60" }));
+    ASSERT_NO_THROW(m_proc = std::make_unique<Process>(Environment::findDependency("cmd.exe"), std::vector<std::string>{ "/c", "ping -n 60 127.0.0.1" }));
 #else
     ASSERT_NO_THROW(m_proc = std::make_unique<Process>(Environment::findDependency("sleep"), std::vector<std::string>{ "60" }));
 #endif