Skip to content

Commit 5e6dc1d

Browse files
committed
Remove libuuid Dependency
1 parent 1928164 commit 5e6dc1d

File tree

9 files changed

+14
-41
lines changed

9 files changed

+14
-41
lines changed

.github/workflows/linux.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ jobs:
3838
uses: johnwason/vcpkg-action@v6
3939
id: vcpkg
4040
with:
41-
pkgs: curl gettext-libintl glib gtest jsoncpp libsecret libuuid maddy openssl
41+
pkgs: curl gettext-libintl glib gtest jsoncpp libsecret maddy openssl
4242
triplet: x64-linux
43-
revision: ee1093857f3d16b007065542bbb2229369c70c2e
43+
revision: 6062c8fe02d38b10d5291411bc235ae4d02cfe6c
4444
token: ${{ secrets.GITHUB_TOKEN }}
4545
github-binarycache: true
4646
- name: "Build"

.github/workflows/macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
with:
3232
pkgs: curl gettext-libintl glib gtest jsoncpp maddy openssl
3333
triplet: arm64-osx
34-
revision: 5f502b165027bbede86ff2c5316334e3398bc519
34+
revision: 6062c8fe02d38b10d5291411bc235ae4d02cfe6c
3535
token: ${{ secrets.GITHUB_TOKEN }}
3636
github-binarycache: true
3737
- name: "Build"

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
with:
3030
pkgs: curl gettext-libintl gtest jsoncpp maddy sqlcipher
3131
triplet: x64-windows
32-
revision: ee1093857f3d16b007065542bbb2229369c70c2e
32+
revision: 6062c8fe02d38b10d5291411bc235ae4d02cfe6c
3333
token: ${{ secrets.GITHUB_TOKEN }}
3434
github-binarycache: true
3535
- name: "Build"

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## 2024.7.3 (next)
44
### Breaking Changes
5+
- Removed the dependency on `libuuid`
56
#### Database
67
- Non-constructor methods will no longer throw exceptions but return true or false upon success.
78
#### Network

CMakeLists.txt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,6 @@ elseif(LINUX)
108108
pkg_check_modules(gthread REQUIRED IMPORTED_TARGET gthread-2.0)
109109
pkg_check_modules(libsecret REQUIRED IMPORTED_TARGET libsecret-1)
110110
target_link_libraries(${PROJECT_NAME} PUBLIC Threads::Threads OpenSSL::SSL OpenSSL::Crypto PkgConfig::glib PkgConfig::gio PkgConfig::gmodule PkgConfig::gobject PkgConfig::gthread PkgConfig::libsecret)
111-
if(USING_VCPKG)
112-
find_package(unofficial-libuuid CONFIG REQUIRED)
113-
target_link_libraries(${PROJECT_NAME} PUBLIC unofficial::UUID::uuid)
114-
else()
115-
find_package(Libuuid REQUIRED)
116-
if(Libuuid_FOUND)
117-
target_include_directories(${PROJECT_NAME} INTERFACE ${Libuuid_INCLUDE_DIRS})
118-
target_link_libraries(${PROJECT_NAME} INTERFACE ${Libuuid_LIBRARIES})
119-
endif()
120-
endif()
121111
elseif(APPLE)
122112
set(THREADS_PREFER_PTHREAD_FLAG ON)
123113
find_library(CF_LIBRARY CoreFoundation)
@@ -143,7 +133,7 @@ install(TARGETS ${PROJECT_NAME} EXPORT "${PROJECT_NAME}Targets" LIBRARY DESTINAT
143133
install(DIRECTORY "${CMAKE_SOURCE_DIR}/include/" DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME}")
144134
install(FILES "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}.pc" DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig")
145135
install(EXPORT "${PROJECT_NAME}Targets" FILE "${PROJECT_NAME}Targets.cmake" NAMESPACE ${PROJECT_NAME}:: DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}")
146-
install(FILES "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}Config.cmake" "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}ConfigVersion.cmake" "${CMAKE_SOURCE_DIR}/cmake/FindLibuuid.cmake" DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}")
136+
install(FILES "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}Config.cmake" "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}ConfigVersion.cmake" DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}")
147137
export(EXPORT "${PROJECT_NAME}Targets" FILE "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}Targets.cmake" NAMESPACE ${PROJECT_NAME}::)
148138

149139
#libnick Test

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ The above dependencies must be installed, *plus* the following for Windows syste
2828
The above dependencies must be installed, *plus* the following for Linux systems:
2929
- glib
3030
- libsecret
31-
- libuuid
3231
- openssl
3332
- Used for sqlcipher, as libnick manually builds sqlcipher on Linux as the vcpkg port is broken.
3433

@@ -66,7 +65,7 @@ A C++20 compiler is also required to build libnick.
6665
1. Run `vcpkg install curl gettext-libintl gtest jsoncpp maddy sqlcipher`
6766
#### Linux
6867
1. Set the `VCPKG_DEFAULT_TRIPLET` environment variable to `x64-linux`
69-
1. Run `vcpkg install curl gettext-libintl glib gtest jsoncpp libsecret libuuid maddy openssl`
68+
1. Run `vcpkg install curl gettext-libintl glib gtest jsoncpp libsecret maddy openssl`
7069
#### macOS (Intel)
7170
1. Set the `VCPKG_DEFAULT_TRIPLET` environment variable to `x64-osx`
7271
1. Run `vcpkg install curl gettext-libintl glib gtest jsoncpp libsecret maddy openssl`

cmake/FindLibuuid.cmake

Lines changed: 0 additions & 17 deletions
This file was deleted.

cmake/config.cmake.in

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ elseif(LINUX)
2828
pkg_check_modules(gobject REQUIRED IMPORTED_TARGET gobject-2.0)
2929
pkg_check_modules(gthread REQUIRED IMPORTED_TARGET gthread-2.0)
3030
pkg_check_modules(libsecret REQUIRED IMPORTED_TARGET libsecret-1)
31-
if(USING_VCPKG)
32-
find_dependency(unofficial-libuuid CONFIG REQUIRED)
33-
else()
34-
list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
35-
find_dependency(Libuuid REQUIRED)
36-
endif()
3731
elseif(APPLE)
3832
find_library(CF_LIBRARY CoreFoundation)
3933
find_library(CS_LIBRARY CoreServices)

manual/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,26 @@ libnick provides Nickvision apps with a common set of cross-platform APIs for ma
88

99
## 2024.7.3 (next)
1010
### Breaking Changes
11+
- Removed the dependency on `libuuid`
1112
#### Database
1213
- Non-constructor methods will no longer throw exceptions but return true or false upon success.
1314
#### Network
1415
- Non-constructor methods will no longer throw exceptions but return true or false upon success.
16+
- Removed `Nickvision::Network::WebClient` class
1517
### New APIs
1618
#### Events
1719
- Added `Nickvision::Events::Event::count()` method
1820
- Added `Nickvision::Events::Event::operator bool()` method
21+
#### Helpers
22+
- Added `Nickvision::Helpers::StringHelpers::newUuid()` method
1923
#### Network
2024
- Added `Nickvision::Network::DNS` namespace
2125
- Added `Nickvision::Network::IPv4Address` class
2226
- Added `Nickvision::Network::MacAddress` class
27+
- Added `Nickvision::Network::Web` class
2328
### Fixes
24-
None
29+
#### Helpers
30+
- Improved GUID/UUID generation in `Nickvision::Helpers::StringHelpers`
2531

2632
## Dependencies
2733
The following are a list of dependencies used by libnick.

0 commit comments

Comments
 (0)