Skip to content

Commit 11e9ef9

Browse files
committed
3 tests skipped. Added example of using mapping in services.
1 parent be5d8e4 commit 11e9ef9

File tree

6 files changed

+21
-5
lines changed

6 files changed

+21
-5
lines changed

ASP.NET Core/Services/AspNetCoreTemplate.Services.Data/AspNetCoreTemplate.Services.Data.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<ItemGroup>
2222
<ProjectReference Include="..\..\Data\AspNetCoreTemplate.Data.Common\AspNetCoreTemplate.Data.Common.csproj" />
2323
<ProjectReference Include="..\..\Data\AspNetCoreTemplate.Data.Models\AspNetCoreTemplate.Data.Models.csproj" />
24+
<ProjectReference Include="..\AspNetCoreTemplate.Services.Mapping\AspNetCoreTemplate.Services.Mapping.csproj" />
2425
</ItemGroup>
2526

2627
</Project>
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
namespace AspNetCoreTemplate.Services.Data
22
{
3+
using System.Collections.Generic;
4+
35
public interface ISettingsService
46
{
57
int GetCount();
8+
9+
IEnumerable<T> GetAll<T>();
610
}
711
}

ASP.NET Core/Services/AspNetCoreTemplate.Services.Data/SettingsService.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
namespace AspNetCoreTemplate.Services.Data
22
{
3+
using System.Collections.Generic;
34
using System.Linq;
45

56
using AspNetCoreTemplate.Data.Common.Repositories;
67
using AspNetCoreTemplate.Data.Models;
8+
using AspNetCoreTemplate.Services.Mapping;
79

810
public class SettingsService : ISettingsService
911
{
@@ -18,5 +20,10 @@ public int GetCount()
1820
{
1921
return this.settingsRepository.All().Count();
2022
}
23+
24+
public IEnumerable<T> GetAll<T>()
25+
{
26+
return this.settingsRepository.All().To<T>().ToList();
27+
}
2128
}
2229
}

ASP.NET Core/Tests/AspNetCoreTemplate.Web.Tests/SeleniumTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public SeleniumTests(SeleniumServerFactory<Startup> server)
2222
this.browser = new RemoteWebDriver(opts);
2323
}
2424

25-
[Fact]
25+
[Fact(Skip = "Example test. Disabled for CI.")]
2626
public void FooterOfThePageContainsPrivacyLink()
2727
{
2828
this.browser.Navigate().GoToUrl(this.server.RootUri);

ASP.NET Core/Tests/AspNetCoreTemplate.Web.Tests/WebTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public WebTests(WebApplicationFactory<Startup> server)
1616
this.server = server;
1717
}
1818

19-
[Fact]
19+
[Fact(Skip = "Example test. Disabled for CI.")]
2020
public async Task IndexPageShouldReturnStatusCode200WithTitle()
2121
{
2222
var client = this.server.CreateClient();
@@ -26,7 +26,7 @@ public async Task IndexPageShouldReturnStatusCode200WithTitle()
2626
Assert.Contains("<title>", responseContent);
2727
}
2828

29-
[Fact]
29+
[Fact(Skip = "Example test. Disabled for CI.")]
3030
public async Task AccountManagePageRequiresAuthorization()
3131
{
3232
var client = this.server.CreateClient(new WebApplicationFactoryClientOptions { AllowAutoRedirect = false });

ASP.NET Core/Web/AspNetCoreTemplate.Web/Controllers/SettingsController.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,27 @@
66

77
using AspNetCoreTemplate.Data.Common.Repositories;
88
using AspNetCoreTemplate.Data.Models;
9+
using AspNetCoreTemplate.Services.Data;
910
using AspNetCoreTemplate.Services.Mapping;
1011
using AspNetCoreTemplate.Web.ViewModels.Settings;
1112

1213
using Microsoft.AspNetCore.Mvc;
1314

1415
public class SettingsController : BaseController
1516
{
17+
private readonly ISettingsService settingsService;
18+
1619
private readonly IDeletableEntityRepository<Setting> repository;
1720

18-
public SettingsController(IDeletableEntityRepository<Setting> repository)
21+
public SettingsController(ISettingsService settingsService, IDeletableEntityRepository<Setting> repository)
1922
{
23+
this.settingsService = settingsService;
2024
this.repository = repository;
2125
}
2226

2327
public IActionResult Index()
2428
{
25-
var settings = this.repository.All().To<SettingViewModel>().ToList();
29+
var settings = this.settingsService.GetAll<SettingViewModel>();
2630
var model = new SettingsListViewModel { Settings = settings };
2731
return this.View(model);
2832
}

0 commit comments

Comments
 (0)