[ASP.NET Core] CI unit test fix by reverting CountAsync change

Author: NikolayIT

ASP.NET Core/Services/AspNetCoreTemplate.Services.Data/ISettingsService.cs

@@ -1,11 +1,10 @@
 namespace AspNetCoreTemplate.Services.Data
 {
     using System.Collections.Generic;
-    using System.Threading.Tasks;
 
     public interface ISettingsService
     {
-        Task<int> GetCountAsync();
+        int GetCount();
 
         IEnumerable<T> GetAll<T>();
     }

ASP.NET Core/Services/AspNetCoreTemplate.Services.Data/SettingsService.cs

@@ -2,14 +2,11 @@
 {
     using System.Collections.Generic;
     using System.Linq;
-    using System.Threading.Tasks;
 
     using AspNetCoreTemplate.Data.Common.Repositories;
     using AspNetCoreTemplate.Data.Models;
     using AspNetCoreTemplate.Services.Mapping;
 
-    using Microsoft.EntityFrameworkCore;
-
     public class SettingsService : ISettingsService
     {
         private readonly IDeletableEntityRepository<Setting> settingsRepository;
@@ -19,9 +16,9 @@ public SettingsService(IDeletableEntityRepository<Setting> settingsRepository)
             this.settingsRepository = settingsRepository;
         }
 
-        public async Task<int> GetCountAsync()
+        public int GetCount()
         {
-            return await this.settingsRepository.All().CountAsync();
+            return this.settingsRepository.All().Count();
         }
 
         public IEnumerable<T> GetAll<T>()

ASP.NET Core/Tests/AspNetCoreTemplate.Services.Data.Tests/SettingsServiceTests.cs

@@ -18,7 +18,7 @@
     public class SettingsServiceTests
     {
         [Fact]
-        public async Task GetCountShouldReturnCorrectNumber()
+        public void GetCountShouldReturnCorrectNumber()
         {
             var repository = new Mock<IDeletableEntityRepository<Setting>>();
             repository.Setup(r => r.All()).Returns(new List<Setting>
@@ -28,7 +28,7 @@ public async Task GetCountShouldReturnCorrectNumber()
                                                             new Setting(),
                                                         }.AsQueryable());
             var service = new SettingsService(repository.Object);
-            Assert.Equal(3, await service.GetCountAsync());
+            Assert.Equal(3, service.GetCount());
             repository.Verify(x => x.All(), Times.Once);
         }
 
@@ -45,7 +45,7 @@ public async Task GetCountShouldReturnCorrectNumberUsingDbContext()
 
             var repository = new EfDeletableEntityRepository<Setting>(dbContext);
             var service = new SettingsService(repository);
-            Assert.Equal(3, await service.GetCountAsync());
+            Assert.Equal(3, service.GetCount());
         }
     }
 }

ASP.NET Core/Tests/Sandbox/Program.cs

@@ -53,7 +53,7 @@ private static async Task<int> SandboxCode(SandboxOptions options, IServiceProvi
             var sw = Stopwatch.StartNew();
 
             var settingsService = serviceProvider.GetService<ISettingsService>();
-            Console.WriteLine($"Count of settings: {await settingsService.GetCountAsync()}");
+            Console.WriteLine($"Count of settings: {settingsService.GetCount()}");
 
             Console.WriteLine(sw.Elapsed);
             return await Task.FromResult(0);

ASP.NET Core/Web/AspNetCoreTemplate.Web/Areas/Administration/Controllers/DashboardController.cs

@@ -16,9 +16,9 @@ public DashboardController(ISettingsService settingsService)
             this.settingsService = settingsService;
         }
 
-        public async Task<IActionResult> Index()
+        public IActionResult Index()
         {
-            var viewModel = new IndexViewModel { SettingsCount = await this.settingsService.GetCountAsync(), };
+            var viewModel = new IndexViewModel { SettingsCount = this.settingsService.GetCount(), };
             return this.View(viewModel);
         }
     }