Slight optimizations

Adding the ''using'' keyword to handle the IDisposable ApplicationDbContext & EfDeletableEntityRepository

Using the .AllAsNoTracking() repository method for when getting the settings count (as it's a read only operation)

Author: IliyanAng

src/Services/AspNetCoreTemplate.Services.Data/SettingsService.cs

@@ -18,7 +18,7 @@ public SettingsService(IDeletableEntityRepository<Setting> settingsRepository)
 
         public int GetCount()
         {
-            return this.settingsRepository.All().Count();
+            return this.settingsRepository.AllAsNoTracking().Count();
         }
 
         public IEnumerable<T> GetAll<T>()

src/Tests/AspNetCoreTemplate.Services.Data.Tests/SettingsServiceTests.cs

@@ -43,7 +43,7 @@ public async Task GetCountShouldReturnCorrectNumberUsingDbContext()
             dbContext.Settings.Add(new Setting());
             await dbContext.SaveChangesAsync();
 
-            var repository = new EfDeletableEntityRepository<Setting>(dbContext);
+            using var repository = new EfDeletableEntityRepository<Setting>(dbContext);
             var service = new SettingsService(repository);
             Assert.Equal(3, service.GetCount());
         }