Skip to content

Commit c2ff170

Browse files
claudeNik Samokhvalov
authored andcommitted
Fix subagent invocation syntax: use natural language, not @
Subagents are invoked via natural language like: 'Use the pg-review subagent to check my patch' Not via @ prefix syntax.
1 parent da2247e commit c2ff170

File tree

1 file changed

+33
-32
lines changed

1 file changed

+33
-32
lines changed

REV/CLAUDE.md

Lines changed: 33 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,70 +4,71 @@ A comprehensive set of subagents for AI-assisted Postgres patch development. The
44

55
## Available Agents
66

7-
All agents are defined in `.claude/agents/` and can be invoked with `@agent-name`.
7+
Agents are defined in `.claude/agents/` and invoked via natural language:
8+
> "Use the **pg-review** subagent to check my patch"
89
910
### Development & Build
1011

1112
| Agent | Description |
1213
|-------|-------------|
13-
| **@pg-build** | Build Postgres from source with debug/coverage/performance configurations |
14-
| **@pg-test** | Run regression tests, TAP tests, and add new test coverage |
15-
| **@pg-benchmark** | Performance testing with pgbench, before/after comparisons |
16-
| **@pg-debug** | Debug issues using GDB, core dumps, and logging |
14+
| **pg-build** | Build Postgres from source with debug/coverage/performance configurations |
15+
| **pg-test** | Run regression tests, TAP tests, and add new test coverage |
16+
| **pg-benchmark** | Performance testing with pgbench, before/after comparisons |
17+
| **pg-debug** | Debug issues using GDB, core dumps, and logging |
1718

1819
### Code Quality
1920

2021
| Agent | Description |
2122
|-------|-------------|
22-
| **@pg-style** | Code style, pgindent, and Postgres conventions |
23-
| **@pg-review** | AI-assisted code review checklist (use PROACTIVELY before submission) |
24-
| **@pg-coverage** | Test coverage analysis and gap identification |
25-
| **@pg-docs** | Documentation in DocBook SGML format |
23+
| **pg-style** | Code style, pgindent, and Postgres conventions |
24+
| **pg-review** | AI-assisted code review checklist (use PROACTIVELY before submission) |
25+
| **pg-coverage** | Test coverage analysis and gap identification |
26+
| **pg-docs** | Documentation in DocBook SGML format |
2627

2728
### Patch Management
2829

2930
| Agent | Description |
3031
|-------|-------------|
31-
| **@pg-patch-create** | Create clean patches with git format-patch |
32-
| **@pg-patch-version** | Manage versions, rebasing, and updates during review cycle |
33-
| **@pg-patch-apply** | Apply and test patches from others (for reviewing) |
32+
| **pg-patch-create** | Create clean patches with git format-patch |
33+
| **pg-patch-version** | Manage versions, rebasing, and updates during review cycle |
34+
| **pg-patch-apply** | Apply and test patches from others (for reviewing) |
3435

3536
### Community Interaction
3637

3738
| Agent | Description |
3839
|-------|-------------|
39-
| **@pg-hackers-letter** | Write effective emails to pgsql-hackers |
40-
| **@pg-commitfest** | Navigate CommitFest workflow and status management |
41-
| **@pg-feedback** | Address reviewer feedback systematically |
40+
| **pg-hackers-letter** | Write effective emails to pgsql-hackers |
41+
| **pg-commitfest** | Navigate CommitFest workflow and status management |
42+
| **pg-feedback** | Address reviewer feedback systematically |
4243

4344
### Quality Gate
4445

4546
| Agent | Description |
4647
|-------|-------------|
47-
| **@pg-readiness** | Comprehensive patch readiness evaluation (use BEFORE submission) |
48+
| **pg-readiness** | Comprehensive patch readiness evaluation (use BEFORE submission) |
4849

4950
---
5051

5152
## Quick Start
5253

53-
```bash
54+
```
5455
# Set up development environment
55-
@pg-build help me build PostgreSQL for development
56+
Use the pg-build subagent to help me build Postgres for development
5657
5758
# Run tests after making changes
58-
@pg-test run regression tests and help me add coverage
59+
Use the pg-test subagent to run regression tests
5960
6061
# Before submitting - check readiness
61-
@pg-readiness evaluate my patch for submission
62+
Use the pg-readiness subagent to evaluate my patch
6263
6364
# Create the patch
64-
@pg-patch-create prepare my changes as a patch
65+
Use the pg-patch-create subagent to prepare my changes
6566
6667
# Write the email
67-
@pg-hackers-letter draft a submission email for my patch
68+
Use the pg-hackers-letter subagent to draft a submission email
6869
6970
# After feedback arrives
70-
@pg-feedback help me address the review comments
71+
Use the pg-feedback subagent to address the review comments
7172
```
7273

7374
---
@@ -80,12 +81,12 @@ In the AI era, **come to pgsql-hackers with a patch**, not just an idea. Draftin
8081
DEVELOP ──► SUBMIT WITH PATCH ──► REVIEW CYCLE ──► COMMIT
8182
│ │ │
8283
▼ ▼ ▼
83-
@pg-build @pg-patch-create @pg-feedback
84-
@pg-test @pg-hackers-letter @pg-patch-version
85-
@pg-style @pg-commitfest
86-
@pg-docs
87-
@pg-review
88-
@pg-readiness
84+
pg-build pg-patch-create pg-feedback
85+
pg-test pg-hackers-letter pg-patch-version
86+
pg-style pg-commitfest
87+
pg-docs
88+
pg-review
89+
pg-readiness
8990
```
9091

9192
**Key Facts:**
@@ -101,9 +102,9 @@ DEVELOP ──► SUBMIT WITH PATCH ──► REVIEW CYCLE ──► COMMIT
101102
| Task | Human | AI Assists |
102103
|------|:-----:|------------|
103104
| **Test with real data** | Required | - |
104-
| **Evaluate architectural fit** | Final call | @pg-review analyzes patterns and fit |
105-
| **Build community consensus** | Owns relationships | @pg-hackers-letter crafts reasoning |
106-
| **Engage with reviewers** | Required | @pg-feedback structures responses |
105+
| **Evaluate architectural fit** | Final call | pg-review analyzes patterns and fit |
106+
| **Build community consensus** | Owns relationships | pg-hackers-letter crafts reasoning |
107+
| **Engage with reviewers** | Required | pg-feedback structures responses |
107108
| **Final judgment calls** | Required | - |
108109

109110
---

0 commit comments

Comments
 (0)