Replace magic number with named constant in format_time bounds check (#30)

* Initial plan

* Replace magic number with MAX_REPLACEMENT_LENGTH constant

Co-authored-by: Nikoro <12560977+Nikoro@users.noreply.github.com>

* Complete feedback implementation

Co-authored-by: Nikoro <12560977+Nikoro@users.noreply.github.com>

* Update linux/system_date_time_format_plugin.cc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Nikoro <12560977+Nikoro@users.noreply.github.com>
Co-authored-by: Dominik Krajcer <dom.kraj@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

_codeql_detected_source_root

@@ -0,0 +1 @@
+.

linux/system_date_time_format_plugin.cc

@@ -91,9 +91,10 @@ char* format_time(const char* time) {
 	char* formatted_time = (char*)malloc(BUFFER_LENGTH);
 	if (!formatted_time) return nullptr;
 
+	const int MAX_REPLACEMENT_LENGTH = 10; // "hh:mm:ss a" is the longest
 	int pos = 0;
 	int i = 0;
-	while (time[i] != '\0' && pos < BUFFER_LENGTH - 15) {
+	while (time[i] != '\0' && pos < BUFFER_LENGTH - MAX_REPLACEMENT_LENGTH) {
 		if (time[i] == '%' && time[i + 1] != '\0') {
 			char specifier = time[i + 1];
 			const char* replacement = nullptr;